RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-23 20:57:41 +00:00
Code Issues Activity Actions

LibWeb: Deallocate DOM timer ID's when the timer goes away

Browse source 
I left a page open overnight and it had run out of timer ID's. :^)
This commit is contained in:
Andreas Kling 2020-11-30 08:03:13 +01:00
parent 8b194f41e9
commit 113da74683
3 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Libraries/LibWeb/DOM/Timer.cpp
View file

@ -54,6 +54,7 @@ Timer::Timer(Window& window, Type type, int milliseconds, JS::Function& callback
Timer::~Timer() Timer::~Timer()
{ {
m_window.deallocate_timer_id({}, m_id);
} }
} }

5
Libraries/LibWeb/DOM/Window.cpp
View file

@ -108,6 +108,11 @@ i32 Window::allocate_timer_id(Badge<Timer>)
return m_timer_id_allocator.allocate(); return m_timer_id_allocator.allocate();
} }
void Window::deallocate_timer_id(Badge<Timer>, i32 id)
{
m_timer_id_allocator.deallocate(id);
}
void Window::clear_timeout(i32 timer_id) void Window::clear_timeout(i32 timer_id)
{ {
m_timers.remove(timer_id); m_timers.remove(timer_id);

1
Libraries/LibWeb/DOM/Window.h
View file

@ -74,6 +74,7 @@ public:
void set_wrapper(Badge<Bindings::WindowObject>, Bindings::WindowObject&); void set_wrapper(Badge<Bindings::WindowObject>, Bindings::WindowObject&);
i32 allocate_timer_id(Badge<Timer>); i32 allocate_timer_id(Badge<Timer>);
void deallocate_timer_id(Badge<Timer>, i32);
void timer_did_fire(Badge<Timer>, Timer&); void timer_did_fire(Badge<Timer>, Timer&);
HighResolutionTime::Performance& performance() { return *m_performance; } HighResolutionTime::Performance& performance() { return *m_performance; }