RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 09:38:11 +00:00
Code Issues Activity Actions

LibJS: Fix incorrect token column values (#2401)

Browse source 
- initializing m_line_column to 1 in the lexer results in incorrect
  column values in tokens on the first line of input.
- not incrementing m_line_column when EOF is reached results in
  an incorrect column value on the last token.
This commit is contained in:
Paul Redmond 2020-05-26 13:00:30 -04:00 • committed by GitHub
parent 7bb69bb9bf
commit 11405c5139
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 15 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibJS/Lexer.cpp
View file

@ -149,8 +149,12 @@ Lexer::Lexer(StringView source)
void Lexer::consume()
{
if (m_position >= m_source.length()) {
m_position = m_source.length() + 1;
if (m_position > m_source.length())
return;
if (m_position == m_source.length()) {
m_position++;
m_line_column++;
m_current_char = EOF;
return;
}