mirror of
https://github.com/RGBCube/serenity
synced 2025-07-26 11:37:44 +00:00
Meta: Make GA logs less misleading
If the job fails early (e.g. during linting), the 'cat debug.log' step would *also* fail. This would confuse GA into thinking that this is the crucial thing and highlights it. This misleads the user into looking at the wrong thing.
This commit is contained in:
parent
100ce8fc1f
commit
115e8f5977
1 changed files with 13 additions and 5 deletions
18
.github/workflows/cmake.yml
vendored
18
.github/workflows/cmake.yml
vendored
|
@ -143,14 +143,22 @@ jobs:
|
||||||
env:
|
env:
|
||||||
SERENITY_KERNEL_CMDLINE: "boot_mode=self-test"
|
SERENITY_KERNEL_CMDLINE: "boot_mode=self-test"
|
||||||
SERENITY_RUN: "ci"
|
SERENITY_RUN: "ci"
|
||||||
run: ninja run
|
run: |
|
||||||
|
echo "::group::ninja run # Qemu output"
|
||||||
|
run_worked=y
|
||||||
|
ninja run || run_worked=n
|
||||||
|
echo "::endgroup::"
|
||||||
|
echo "::group::cat debug.log # Serenity output"
|
||||||
|
if [ "y" = "${run_worked}" ] ; then
|
||||||
|
cat debug.log
|
||||||
|
else
|
||||||
|
echo "skipped (qemu had non-zero exit-code)"
|
||||||
|
fi
|
||||||
|
echo "::endgroup::"
|
||||||
|
[ "y" = ${run_worked} ]
|
||||||
timeout-minutes: 10
|
timeout-minutes: 10
|
||||||
# FIXME: When stable, remove continue on error. (See issue #5541)
|
# FIXME: When stable, remove continue on error. (See issue #5541)
|
||||||
continue-on-error: true
|
continue-on-error: true
|
||||||
- name: Print target logs
|
|
||||||
if: ${{ !cancelled() && matrix.debug-macros == 'NORMAL_DEBUG'}}
|
|
||||||
working-directory: ${{ github.workspace }}/Build
|
|
||||||
run: cat ./debug.log
|
|
||||||
|
|
||||||
build_and_test_lagom:
|
build_and_test_lagom:
|
||||||
runs-on: ${{ matrix.os }}
|
runs-on: ${{ matrix.os }}
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue