RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:07:35 +00:00
Code Issues Activity Actions

Libraries: Use default constructors/destructors in LibCards

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-26 09:05:16 -07:00 • committed by Brian Gianforcaro
parent 2200eb761d
commit 11b28c88fc
2 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibCards/Card.cpp
View file

@ -139,10 +139,6 @@ Card::Card(Type type, uint8_t value)
m_front_inverted = invert_bitmap(*m_front); m_front_inverted = invert_bitmap(*m_front);
} }
Card::~Card()
{
}
void Card::draw(GUI::Painter& painter) const void Card::draw(GUI::Painter& painter) const
{ {
VERIFY(!s_background.is_null()); VERIFY(!s_background.is_null());

3
Userland/Libraries/LibCards/Card.h
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2020, Till Mayer <till.mayer@web.de> * Copyright (c) 2020, Till Mayer <till.mayer@web.de>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -36,7 +37,7 @@ public:
__Count __Count
}; };
virtual ~Card() override; virtual ~Card() override = default;
Gfx::IntRect& rect() { return m_rect; } Gfx::IntRect& rect() { return m_rect; }
Gfx::IntPoint position() const { return m_rect.location(); } Gfx::IntPoint position() const { return m_rect.location(); }