RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 15:12:45 +00:00
Code Issues Activity Actions

LibWeb+WebContent: Separate painting command list from RecordingPainter

Browse source 
Separating the recorder list from the painter will allow us to save it
for later execution without carrying along the painter's state. This
will be useful once we have a separate thread for executing painting
commands, to which we will have to transfer commands from the main
thread.

Preparation for https://github.com/SerenityOS/serenity/pull/23108
This commit is contained in:
Aliaksandr Kalenik 2024-02-14 16:36:42 +01:00 • committed by Andreas Kling
parent ce9ad3a236
commit 11d746a67f
11 changed files with 874 additions and 732 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Services/WebContent/PageClient.cpp
View file

@ -189,7 +189,8 @@ Web::Layout::Viewport* PageClient::layout_root()
void PageClient::paint(Web::DevicePixelRect const& content_rect, Gfx::Bitmap& target, Web::PaintOptions paint_options)
{
Web::Painting::RecordingPainter recording_painter;
Web::Painting::CommandList painting_commands;
Web::Painting::RecordingPainter recording_painter(painting_commands);
Gfx::IntRect bitmap_rect { {}, content_rect.size().to_type<int>() };
recording_painter.fill_rect(bitmap_rect, Web::CSS::SystemColor::canvas());
@ -203,7 +204,7 @@ void PageClient::paint(Web::DevicePixelRect const& content_rect, Gfx::Bitmap& ta
if (s_use_gpu_painter) {
#ifdef HAS_ACCELERATED_GRAPHICS
Web::Painting::PaintingCommandExecutorGPU painting_command_executor(*m_accelerated_graphics_context, target);
recording_painter.execute(painting_command_executor);
painting_commands.execute(painting_command_executor);
#else
static bool has_warned_about_configuration = false;
@ -214,7 +215,7 @@ void PageClient::paint(Web::DevicePixelRect const& content_rect, Gfx::Bitmap& ta
#endif
} else {
Web::Painting::PaintingCommandExecutorCPU painting_command_executor(target);
recording_painter.execute(painting_command_executor);
painting_commands.execute(painting_command_executor);
}
}