RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:07:35 +00:00
Code Issues Activity Actions

Kernel: Get RefPtr<Device> from the DeviceManagement::get_device method

Browse source 
Instead of returning a raw pointer, which could be technically invalid
when using it in the caller function, we return a valid RefPtr of such
device.

This ensures that the code in DevPtsFS is now safe from a rare race
condition in which the SlavePTY device is gone but we still have a
pointer to it.
This commit is contained in:
Liav A 2024-03-04 21:19:31 +02:00 • committed by Andrew Kaster
parent 5dcf03ad9a
commit 11ead5c84f
6 changed files with 24 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Kernel/FileSystem/DevPtsFS/Inode.h
View file

@ -23,7 +23,10 @@ public:
DevPtsFS const& fs() const { return static_cast<DevPtsFS const&>(Inode::fs()); }
private:
DevPtsFSInode(DevPtsFS&, InodeIndex, SlavePTY*);
DevPtsFSInode(DevPtsFS&, InodeIndex, SlavePTY&);
// NOTE: This constructor is used for the root inode only.
DevPtsFSInode(DevPtsFS&);
// ^Inode
virtual ErrorOr<size_t> read_bytes_locked(off_t, size_t, UserOrKernelBuffer& buffer, OpenFileDescription*) const override;