RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:57:35 +00:00
Code Issues Activity Actions

Kernel: Add Credentials to hold a set of user and group IDs

Browse source 
This patch adds a new object to hold a Process's user credentials:

- UID, EUID, SUID
- GID, EGID, SGID, extra GIDs

Credentials are immutable and child processes initially inherit the
Credentials object from their parent.

Whenever a process changes one or more of its user/group IDs, a new
Credentials object is constructed.

Any code that wants to inspect and act on a set of credentials can now
do so without worrying about data races.
This commit is contained in:
Andreas Kling 2022-08-20 18:25:54 +02:00
parent bec314611d
commit 122d7d9533
11 changed files with 366 additions and 128 deletions
Download patch file Download diff file Expand all files Collapse all files

39
Kernel/Syscalls/getuid.cpp
View file

@ -36,35 +36,50 @@ ErrorOr<FlatPtr> Process::sys$getegid()
return egid().value();
}
ErrorOr<FlatPtr> Process::sys$getresuid(Userspace<UserID*> ruid, Userspace<UserID*> euid, Userspace<UserID*> suid)
ErrorOr<FlatPtr> Process::sys$getresuid(Userspace<UserID*> user_ruid, Userspace<UserID*> user_euid, Userspace<UserID*> user_suid)
{
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this);
TRY(require_promise(Pledge::stdio));
TRY(copy_to_user(ruid, &m_protected_values.uid));
TRY(copy_to_user(euid, &m_protected_values.euid));
TRY(copy_to_user(suid, &m_protected_values.suid));
auto credentials = this->credentials();
auto uid = credentials->uid();
auto euid = credentials->euid();
auto suid = credentials->suid();
TRY(copy_to_user(user_ruid, &uid));
TRY(copy_to_user(user_euid, &euid));
TRY(copy_to_user(user_suid, &suid));
return 0;
}
ErrorOr<FlatPtr> Process::sys$getresgid(Userspace<GroupID*> rgid, Userspace<GroupID*> egid, Userspace<GroupID*> sgid)
ErrorOr<FlatPtr> Process::sys$getresgid(Userspace<GroupID*> user_rgid, Userspace<GroupID*> user_egid, Userspace<GroupID*> user_sgid)
{
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this);
TRY(require_promise(Pledge::stdio));
TRY(copy_to_user(rgid, &m_protected_values.gid));
TRY(copy_to_user(egid, &m_protected_values.egid));
TRY(copy_to_user(sgid, &m_protected_values.sgid));
auto credentials = this->credentials();
auto gid = credentials->gid();
auto egid = credentials->egid();
auto sgid = credentials->sgid();
TRY(copy_to_user(user_rgid, &gid));
TRY(copy_to_user(user_egid, &egid));
TRY(copy_to_user(user_sgid, &sgid));
return 0;
}
ErrorOr<FlatPtr> Process::sys$getgroups(size_t count, Userspace<gid_t*> user_gids)
ErrorOr<FlatPtr> Process::sys$getgroups(size_t count, Userspace<GroupID*> user_gids)
{
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this);
TRY(require_promise(Pledge::stdio));
auto credentials = this->credentials();
if (!count)
return extra_gids().size();
if (count != extra_gids().size())
return credentials->extra_gids().size();
if (count != credentials->extra_gids().size())
return EINVAL;
TRY(copy_to_user(user_gids, extra_gids().data(), sizeof(gid_t) * count));
TRY(copy_to_user(user_gids, credentials->extra_gids().data(), sizeof(GroupID) * count));
return 0;
}