RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 21:27:36 +00:00
Code Issues Activity Actions

LibWeb: Fix building of areas spanning multiple rows in GFC

Browse source 
Rewrites the grid area building to accurately identify areas that span
multiple rows. Also now we can recognize invalid areas but do not
handle them yet.
This commit is contained in:
Aliaksandr Kalenik 2023-10-22 18:48:35 +02:00 • committed by Andreas Kling
parent 8eab44896a
commit 122d847720
8 changed files with 194 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

44
Tests/LibWeb/Layout/expected/grid/template-areas-3.txt Normal file
View file

@ -0,0 +1,44 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x692 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 780x674 children: not-inline
Box <div.grid> at (11,11) content-size 778x672 [GFC] children: not-inline
BlockContainer <div.a> at (12,12) content-size 775.984375x334 [BFC] children: inline
line 0 width: 9.34375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [12,12 9.34375x17.46875]
"a"
TextNode <#text>
BlockContainer <div.b> at (12,348) content-size 257.328125x334 [BFC] children: inline
line 0 width: 9.46875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [12,348 9.46875x17.46875]
"b"
TextNode <#text>
BlockContainer <div.c> at (271.328125,348) content-size 257.328125x334 [BFC] children: inline
line 0 width: 8.890625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [271.328125,348 8.890625x17.46875]
"c"
TextNode <#text>
BlockContainer <div.d> at (530.65625,348) content-size 257.328125x166 [BFC] children: inline
line 0 width: 7.859375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [530.65625,348 7.859375x17.46875]
"d"
TextNode <#text>
BlockContainer <div.e> at (530.65625,516) content-size 257.328125x166 [BFC] children: inline
line 0 width: 8.71875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [530.65625,516 8.71875x17.46875]
"e"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600] overflow: [0,0 800x694]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x694]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x676]
PaintableBox (Box<DIV>.grid) [10,10 780x674]
PaintableWithLines (BlockContainer<DIV>.a) [11,11 777.984375x336]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.b) [11,347 259.328125x336]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.c) [270.328125,347 259.328125x336]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.d) [529.65625,347 259.328125x168]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.e) [529.65625,515 259.328125x168]
TextPaintable (TextNode<#text>)