RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 03:17:34 +00:00
Code Issues Activity Actions

LibJS: Make class definition evaluation more spec like in ordering

Browse source
This commit is contained in:
davidot 2021-10-07 01:09:04 +02:00 • committed by Linus Groh
parent d3ef08217b
commit 1245512c50
6 changed files with 258 additions and 131 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp
View file

@ -275,7 +275,9 @@ void ECMAScriptFunctionObject::visit_edges(Visitor& visitor)
visitor.visit(m_home_object);
for (auto& field : m_fields) {
field.name.visit_edges(visitor);
if (field.name.is_symbol())
visitor.visit(field.name.as_symbol());
visitor.visit(field.initializer);
}
}

4
Userland/Libraries/LibJS/Runtime/ECMAScriptFunctionObject.h
View file

@ -59,14 +59,14 @@ public:
void set_home_object(Object* home_object) { m_home_object = home_object; }
struct InstanceField {
StringOrSymbol name;
PropertyName name;
ECMAScriptFunctionObject* initializer { nullptr };
void define_field(VM& vm, Object& receiver) const;
};
Vector<InstanceField> const& fields() const { return m_fields; }
void add_field(StringOrSymbol property_key, ECMAScriptFunctionObject* initializer) { m_fields.empend(property_key, initializer); }
void add_field(PropertyName property_key, ECMAScriptFunctionObject* initializer) { m_fields.empend(property_key, initializer); }
// This is for IsSimpleParameterList (static semantics)
bool has_simple_parameter_list() const { return m_has_simple_parameter_list; }