RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:27:45 +00:00
Code Issues Activity Actions

AK: Fix StringUtils tests to actually observe return value.

Browse source 
Noticed this while playing around with making Optional<T>
nodiscard.
This commit is contained in:
Brian Gianforcaro 2020-08-05 03:11:59 -07:00 • committed by Andreas Kling
parent 88092376f3
commit 125eab998f
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
AK/Tests/TestStringUtils.cpp
View file

@ -72,16 +72,16 @@ TEST_CASE(convert_to_int)
auto value = AK::StringUtils::convert_to_int(StringView()); auto value = AK::StringUtils::convert_to_int(StringView());
EXPECT(!value.has_value()); EXPECT(!value.has_value());
AK::StringUtils::convert_to_int(""); value = AK::StringUtils::convert_to_int("");
EXPECT(!value.has_value()); EXPECT(!value.has_value());
AK::StringUtils::convert_to_int("a"); value = AK::StringUtils::convert_to_int("a");
EXPECT(!value.has_value()); EXPECT(!value.has_value());
AK::StringUtils::convert_to_int("+"); value = AK::StringUtils::convert_to_int("+");
EXPECT(!value.has_value()); EXPECT(!value.has_value());
AK::StringUtils::convert_to_int("-"); value = AK::StringUtils::convert_to_int("-");
EXPECT(!value.has_value()); EXPECT(!value.has_value());
auto actual = AK::StringUtils::convert_to_int("0"); auto actual = AK::StringUtils::convert_to_int("0");
@ -133,7 +133,7 @@ TEST_CASE(convert_to_uint)
value = AK::StringUtils::convert_to_uint("+1"); value = AK::StringUtils::convert_to_uint("+1");
EXPECT(!value.has_value()); EXPECT(!value.has_value());
AK::StringUtils::convert_to_uint("-1"); value = AK::StringUtils::convert_to_uint("-1");
EXPECT(!value.has_value()); EXPECT(!value.has_value());
auto actual = AK::StringUtils::convert_to_uint("0"); auto actual = AK::StringUtils::convert_to_uint("0");