RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 02:57:42 +00:00
Code Issues Activity Actions

LibWeb: Use parse_length_percentage() for radial-gradient radii

Browse source
This commit is contained in:
Sam Atkins 2023-12-28 12:51:56 +00:00 • committed by Andreas Kling
parent e62d692205
commit 12bcd029ff
1 changed files with 10 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

23
Userland/Libraries/LibWeb/CSS/Parser/GradientParsing.cpp
View file

@ -444,29 +444,26 @@ RefPtr<StyleValue> Parser::parse_radial_gradient_function(ComponentValue const&
tokens.skip_whitespace(); tokens.skip_whitespace();
if (!tokens.has_next_token()) if (!tokens.has_next_token())
return {}; return {};
auto& token = tokens.next_token(); if (tokens.peek_token().is(Token::Type::Ident)) {
if (token.is(Token::Type::Ident)) { auto extent = parse_extent_keyword(tokens.next_token().token().ident());
auto extent = parse_extent_keyword(token.token().ident());
if (!extent.has_value()) if (!extent.has_value())
return {}; return {};
return commit_value(*extent, transaction_size); return commit_value(*extent, transaction_size);
} }
auto first_dimension = parse_dimension(token); auto first_radius = parse_length_percentage(tokens);
if (!first_dimension.has_value()) if (!first_radius.has_value())
return {};
if (!first_dimension->is_length_percentage())
return {}; return {};
auto transaction_second_dimension = tokens.begin_transaction(); auto transaction_second_dimension = tokens.begin_transaction();
tokens.skip_whitespace(); tokens.skip_whitespace();
if (tokens.has_next_token()) { if (tokens.has_next_token()) {
auto& second_token = tokens.next_token(); auto second_radius = parse_length_percentage(tokens);
auto second_dimension = parse_dimension(second_token); if (second_radius.has_value())
if (second_dimension.has_value() && second_dimension->is_length_percentage()) return commit_value(EllipseSize { first_radius.release_value(), second_radius.release_value() },
return commit_value(EllipseSize { first_dimension->length_percentage(), second_dimension->length_percentage() },
transaction_size, transaction_second_dimension); transaction_size, transaction_second_dimension);
} }
if (first_dimension->is_length()) // FIXME: Support calculated lengths
return commit_value(CircleSize { first_dimension->length() }, transaction_size); if (first_radius->is_length())
return commit_value(CircleSize { first_radius->length() }, transaction_size);
return {}; return {};
}; };