RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:27:45 +00:00
Code Issues Activity Actions

LibGfx/TIFF: Rename JPEG to OldJPEG and introduce a new JPEG tag

Browse source 
Support for JPEGs embedded in TIFF images was introduced with TIFF 6.0.
However, this implementation had major issues. It was so problematic
that they decided to reimplement it from scratch in 1995, three years
later. The two incarnations are obviously incompatible.

For more details see:
https://www.awaresystems.be/imaging/tiff/specification/TIFFTechNote2.txt
This commit is contained in:
Lucas CHOLLET 2024-01-18 22:44:53 -05:00 • committed by Andrew Kaster
parent 1faf9bb44f
commit 12c38035db
2 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.h
View file

@ -17,6 +17,10 @@ namespace Gfx {
// First TIFF Technical notes from 1995 // First TIFF Technical notes from 1995
// https://www.awaresystems.be/imaging/tiff/specification/TIFFPM6.pdf // https://www.awaresystems.be/imaging/tiff/specification/TIFFPM6.pdf
// Second TIFF Technical notes from 1995
// The document is the second (and current) specification for embedded JPEGs in TIFF images.
// https://www.awaresystems.be/imaging/tiff/specification/TIFFTechNote2.txt
// This is also compatible with Exif as it is, basically, another set of TIFF tags: // This is also compatible with Exif as it is, basically, another set of TIFF tags:
// The spec is named "Exchangeable image file format for digital still cameras: Exif Version 3.0" // The spec is named "Exchangeable image file format for digital still cameras: Exif Version 3.0"
// And it can be found at https://www.cipa.jp/e/std/std-sec.html // And it can be found at https://www.cipa.jp/e/std/std-sec.html

3
Userland/Libraries/LibGfx/TIFFGenerator.py
View file

@ -55,7 +55,8 @@ class Compression(EnumWithExportName):
Group3Fax = 3 Group3Fax = 3
Group4Fax = 4 Group4Fax = 4
LZW = 5 LZW = 5
JPEG = 6 OldJPEG = 6
JPEG = 7
AdobeDeflate = 8 AdobeDeflate = 8
PackBits = 32773 PackBits = 32773
PixarDeflate = 32946 # This is the old (and deprecated) code for AdobeDeflate PixarDeflate = 32946 # This is the old (and deprecated) code for AdobeDeflate