RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-30 21:58:10 +00:00
Code Issues Activity Actions

LibGUI: Ensure GlyphMapWidget selection resets when requested

Browse source 
Previously selection reset was ignored on active glyph change if the
old glyph equaled the new one. This was an intentional behavior that
allowed selections to resize by dragging the focused glyph, but has
proved more counterintuitive than useful.

Now the widget behaves like other text selection controls: selections
can be reset by clicking anywhere in them or shift can be held to
grow the selection.
This commit is contained in:
thankyouverycool 2022-12-15 12:03:07 -05:00 • committed by Andreas Kling
parent 360e58a276
commit 12cd30f1ac
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGUI/GlyphMapWidget.cpp
View file

@ -77,7 +77,7 @@ void GlyphMapWidget::resize_event(ResizeEvent& event)
void GlyphMapWidget::set_active_glyph(int glyph, ShouldResetSelection should_reset_selection)
{
if (m_active_glyph == glyph)
if (m_active_glyph == glyph && should_reset_selection == ShouldResetSelection::No)
return;
m_active_glyph = glyph;
if (should_reset_selection == ShouldResetSelection::Yes) {