RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 04:57:45 +00:00
Code Issues Activity Actions

Kernel/Graphics: Disable double buffering for the VirtIO driver

Browse source 
The performance that we achieve from this technique is visually worse
compared to turning off this feature, so let's not use this until we
figure out why it happens.
This commit is contained in:
Liav A 2022-12-16 15:37:32 +02:00 • committed by Sam Atkins
parent bb491a681d
commit 12d4bbbd11
3 changed files with 12 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Kernel/Graphics/VirtIOGPU/DisplayConnector.h
View file

@ -42,7 +42,7 @@ public:
private:
void initialize_console();
virtual bool mutable_mode_setting_capable() const override { return true; }
virtual bool double_framebuffering_capable() const override { return true; }
virtual bool double_framebuffering_capable() const override { return false; }
virtual bool partial_flush_support() const override { return true; }
virtual ErrorOr<void> set_mode_setting(ModeSetting const&) override;
virtual ErrorOr<void> set_safe_mode_setting() override;
@ -86,9 +86,6 @@ private:
Graphics::VirtIOGPU::Protocol::DisplayInfoResponse::Display m_display_info {};
Graphics::VirtIOGPU::ScanoutID m_scanout_id;
// 2D framebuffer Member data
Atomic<size_t, AK::memory_order_relaxed> m_last_set_buffer_index { 0 };
constexpr static size_t NUM_TRANSFER_REGION_PAGES = 256;
};