RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-29 11:45:11 +00:00
Code Issues Activity Actions

LibGUI+Taskbar: Don't immediately repaint checkable Buttons

Browse source 
Unlike regular buttons, unchecked checkables don't need to repaint
on MouseUp to feel responsive when clicking rapidly. In fact, this
can lead to a flickering effect when a bogus unchecked state gets
painted again before the button's checked one.
This commit is contained in:
thankyouverycool 2022-09-04 07:54:54 -04:00 • committed by Linus Groh
parent 56a719daf8
commit 12ee92004d
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibGUI/AbstractButton.cpp
View file

@ -134,7 +134,8 @@ void AbstractButton::mouseup_event(MouseEvent& event)
bool was_being_pressed = m_being_pressed; bool was_being_pressed = m_being_pressed;
m_being_pressed = false; m_being_pressed = false;
m_pressed_mouse_button = MouseButton::None; m_pressed_mouse_button = MouseButton::None;
repaint(); if (!is_checkable() || is_checked())
repaint();
if (was_being_pressed && !was_auto_repeating) { if (was_being_pressed && !was_auto_repeating) {
switch (event.button()) { switch (event.button()) {
case MouseButton::Primary: case MouseButton::Primary: