RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-23 16:47:41 +00:00
Code Issues Activity Actions

LibHTTP: Remove attempt to read extra line after response headers

Browse source 
When LibHTTP encountered the blank line between the headers and the body
in a HTTP response it made a call the m_socket->can_read_line(). This
ultimately tried to find a newline in the stream. If the response body
was small and did not contain a new line then the request would hang.

The call to m_socket->can_read_line() is removed so that the code is
able to progress into the body reading loop.
This commit is contained in:
Wesley Moore 2022-02-12 08:01:46 +10:00 • committed by Ali Mohammad Pur
parent 2925725c9a
commit 12ff5c9bfd
1 changed files with 0 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibHTTP/Job.cpp
View file

@ -316,12 +316,6 @@ void Job::on_socket_connected()
if (m_code == 204) if (m_code == 204)
return finish_up(); return finish_up();
can_read_line = m_socket->can_read_line();
if (can_read_line.is_error())
return deferred_invoke([this] { did_fail(Core::NetworkJob::Error::TransmissionFailed); });
if (!can_read_line.value())
return;
break; break;
} }
auto parts = line.split_view(':'); auto parts = line.split_view(':');