RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 06:27:45 +00:00
Code Issues Activity Actions

LibWeb: Mark abort event as trusted before dispatching it

Browse source 
This matches the behavior of Firefox and Chrome.
This commit is contained in:
Tim Ledbetter 2024-03-10 19:33:31 +00:00 • committed by Andreas Kling
parent 3bec616893
commit 130f28cf50
3 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/abortsignal-timeout.txt
View file

@ -1,2 +1,3 @@
Time passed before abort event fired is at least 10 milliseconds: true Time passed before abort event fired is at least 10 milliseconds: true
Reason type: TimeoutError Reason type: TimeoutError
onabort event isTrusted: true

3
Tests/LibWeb/Text/input/abortsignal-timeout.html
View file

@ -4,11 +4,12 @@
const timeout_milliseconds = 10; const timeout_milliseconds = 10;
const test_start_time = performance.now(); const test_start_time = performance.now();
const signal = AbortSignal.timeout(timeout_milliseconds); const signal = AbortSignal.timeout(timeout_milliseconds);
signal.onabort = () => { signal.onabort = (event) => {
const abort_event_time = performance.now(); const abort_event_time = performance.now();
const time_taken_milliseconds = abort_event_time - test_start_time; const time_taken_milliseconds = abort_event_time - test_start_time;
println(`Time passed before abort event fired is at least ${timeout_milliseconds} milliseconds: ${time_taken_milliseconds >= timeout_milliseconds}`); println(`Time passed before abort event fired is at least ${timeout_milliseconds} milliseconds: ${time_taken_milliseconds >= timeout_milliseconds}`);
println(`Reason type: ${signal.reason.name}`); println(`Reason type: ${signal.reason.name}`);
println(`onabort event isTrusted: ${event.isTrusted}`);
done(); done();
}; };
}); });

4
Userland/Libraries/LibWeb/DOM/AbortSignal.cpp
View file

@ -64,7 +64,9 @@ void AbortSignal::signal_abort(JS::Value reason)
m_abort_algorithms.clear(); m_abort_algorithms.clear();
// 5. Fire an event named abort at signal. // 5. Fire an event named abort at signal.
dispatch_event(Event::create(realm(), HTML::EventNames::abort)); auto abort_event = Event::create(realm(), HTML::EventNames::abort);
abort_event->set_is_trusted(true);
dispatch_event(abort_event);
} }
void AbortSignal::set_onabort(WebIDL::CallbackType* event_handler) void AbortSignal::set_onabort(WebIDL::CallbackType* event_handler)