RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:27:45 +00:00
Code Issues Activity Actions

LibJS: Partially revert 12b283f

Browse source 
This commit partially reverts "LibJS: Make accessing the current
function's arguments cheaper".
While the change passed all the currently passing test262 tests, it
seems to have _some_ flaw that silently breaks with some real-world
websites.
As the speedup with negligible at best, let's just revert it until we
can implement it more correctly.
This commit is contained in:
Ali Mohammad Pur 2021-10-08 19:56:02 +03:30
parent fa6c06ce8d
commit 13138811df
4 changed files with 0 additions and 107 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Userland/Libraries/LibJS/Runtime/Reference.h
View file

@ -55,28 +55,6 @@ public:
{
}
Reference(FlyString referenced_name, size_t function_argument_index, bool strict = false, ExecutionContext* function_context = nullptr)
: m_base_type(BaseType::Environment)
, m_base_environment(nullptr)
, m_name(move(referenced_name))
, m_strict(strict)
, m_environment_coordinate({})
, m_function_argument_index(function_argument_index)
, m_referenced_function_context(function_context)
{
}
Reference(Environment& base, FlyString referenced_name, size_t function_argument_index, bool strict = false, Optional<EnvironmentCoordinate> environment_coordinate = {}, ExecutionContext* function_context = nullptr)
: m_base_type(BaseType::Environment)
, m_base_environment(&base)
, m_name(move(referenced_name))
, m_strict(strict)
, m_environment_coordinate(move(environment_coordinate))
, m_function_argument_index(function_argument_index)
, m_referenced_function_context(function_context)
{
}
Value base() const
{
VERIFY(m_base_type == BaseType::Value);
@ -157,8 +135,6 @@ private:
Value m_this_value;
bool m_strict { false };
Optional<EnvironmentCoordinate> m_environment_coordinate;
Optional<size_t> m_function_argument_index;
ExecutionContext* m_referenced_function_context { nullptr };
};
}