RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 18:57:34 +00:00
Code Issues Activity Actions

Spreadsheet: Throw if lookup value doesn't exist and no default is given

Browse source 
And explicitly state which value wasn't found and where in the error.
This commit is contained in:
Ali Mohammad Pur 2022-06-25 21:33:26 +04:30 • committed by Linus Groh
parent 746b8ec8de
commit 135683795b
2 changed files with 14 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Applications/Spreadsheet/Tests/free-functions.js
View file

@ -191,7 +191,7 @@ describe("Lookup", () => {
expect(lookup).toBeDefined();
// Note: String ordering.
expect(lookup("2", R`A0:A9`, R`B0:B9`)).toEqual("B2");
expect(lookup("20", R`A0:A9`, R`B0:B9`)).toBeUndefined();
expect(() => lookup("20", R`A0:A9`, R`B0:B9`)).toThrow();
expect(lookup("80", R`A0:A9`, R`B0:B9`, undefined, "nextlargest")).toEqual("B9");
});
@ -199,7 +199,7 @@ describe("Lookup", () => {
expect(reflookup).toBeDefined();
// Note: String ordering.
expect(reflookup("2", R`A0:A9`, R`B0:B9`).name).toEqual("B2");
expect(reflookup("20", R`A0:A9`, R`B0:B9`)).toEqual(here());
expect(() => reflookup("20", R`A0:A9`, R`B0:B9`)).toThrow();
expect(reflookup("80", R`A0:A9`, R`B0:B9`, undefined, "nextlargest").name).toEqual("B9");
});
});