1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:07:45 +00:00

LibWeb: Protect RadioButton and TextNode against mutating DOM

RadioButton had some protection, but also needed to be protected against
click events originating from its associated label.
This commit is contained in:
Timothy Flynn 2021-04-04 11:45:39 -04:00 committed by Andreas Kling
parent 2199a59614
commit 1380dbeef3
2 changed files with 7 additions and 0 deletions

View file

@ -115,6 +115,9 @@ void RadioButton::handle_associated_label_mousedown(Badge<Label>)
void RadioButton::handle_associated_label_mouseup(Badge<Label>)
{
// NOTE: Changing the checked state of the DOM node may run arbitrary JS, which could disappear this node.
NonnullRefPtr protect = *this;
set_checked_within_group();
m_being_pressed = false;
}