From 13824392678d7f78d65f4cbed44ffaa546cac6fc Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Mon, 3 Apr 2023 13:34:00 +0200 Subject: [PATCH] Kernel: Mark sys$getpgrp as not needing the big lock Access to the process's process group is already serialized by SpinlockProtected. --- Kernel/API/Syscall.h | 2 +- Kernel/Syscalls/setpgid.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Kernel/API/Syscall.h b/Kernel/API/Syscall.h index 9da9230427..00a56a5d20 100644 --- a/Kernel/API/Syscall.h +++ b/Kernel/API/Syscall.h @@ -97,7 +97,7 @@ enum class NeedsBigProcessLock { S(getkeymap, NeedsBigProcessLock::No) \ S(getpeername, NeedsBigProcessLock::Yes) \ S(getpgid, NeedsBigProcessLock::No) \ - S(getpgrp, NeedsBigProcessLock::Yes) \ + S(getpgrp, NeedsBigProcessLock::No) \ S(getpid, NeedsBigProcessLock::No) \ S(getppid, NeedsBigProcessLock::No) \ S(getrandom, NeedsBigProcessLock::No) \ diff --git a/Kernel/Syscalls/setpgid.cpp b/Kernel/Syscalls/setpgid.cpp index 738f78e508..39dc2b4d94 100644 --- a/Kernel/Syscalls/setpgid.cpp +++ b/Kernel/Syscalls/setpgid.cpp @@ -61,7 +61,7 @@ ErrorOr Process::sys$getpgid(pid_t pid) ErrorOr Process::sys$getpgrp() { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::stdio)); return pgid().value(); }