RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:17:35 +00:00
Code Issues Activity Actions

LibGUI: Add up & down arrow hooks and input history to TextBox

Browse source 
This patch adds the ability to enable "input history" on a textbox,
allowing to navigate between the history with the arrow keys.

Also removes a custom TextBox subclass from HackStudio that added
the exact same hooks, and moves it to use the now standard ones.
This commit is contained in:
FalseHonesty 2020-05-26 22:17:06 -04:00 • committed by Andreas Kling
parent 893a9ff5b0
commit 139dbfd5b5
4 changed files with 74 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

28
DevTools/HackStudio/Locator.cpp
View file

@ -73,28 +73,6 @@ private:
Vector<String> m_suggestions;
};
class LocatorTextBox final : public GUI::TextBox {
C_OBJECT(LocatorTextBox)
public:
virtual ~LocatorTextBox() override {}
Function<void()> on_up;
Function<void()> on_down;
virtual void keydown_event(GUI::KeyEvent& event) override
{
if (event.key() == Key_Up)
on_up();
else if (event.key() == Key_Down)
on_down();
GUI::TextBox::keydown_event(event);
}
private:
LocatorTextBox() {}
};
Locator::Locator()
{
if (!s_cplusplus_icon) {
@ -106,14 +84,14 @@ Locator::Locator()
set_layout<GUI::VerticalBoxLayout>();
set_size_policy(GUI::SizePolicy::Fill, GUI::SizePolicy::Fixed);
set_preferred_size(0, 20);
m_textbox = add<LocatorTextBox>();
m_textbox = add<GUI::TextBox>();
m_textbox->on_change = [this] {
update_suggestions();
};
m_textbox->on_escape_pressed = [this] {
m_popup_window->hide();
};
m_textbox->on_up = [this] {
m_textbox->on_up_pressed = [this] {
GUI::ModelIndex new_index = m_suggestion_view->selection().first();
if (new_index.is_valid())
new_index = m_suggestion_view->model()->index(new_index.row() - 1);
@ -125,7 +103,7 @@ Locator::Locator()
m_suggestion_view->scroll_into_view(new_index, Orientation::Vertical);
}
};
m_textbox->on_down = [this] {
m_textbox->on_down_pressed = [this] {
GUI::ModelIndex new_index = m_suggestion_view->selection().first();
if (new_index.is_valid())
new_index = m_suggestion_view->model()->index(new_index.row() + 1);