From 13a2e91fc5a07c440eb1a1102b6698790d97c10b Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Fri, 23 Jul 2021 14:14:19 +0200 Subject: [PATCH] Kernel: No need to use safe_memcpy() when handling an inode fault We're copying the inode contents from a stack buffer into a page that we just quick-mapped, so there's no reason for this memcpy() to fail. --- Kernel/VM/Region.cpp | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/Kernel/VM/Region.cpp b/Kernel/VM/Region.cpp index b9c7cd020a..5ba828f9b9 100644 --- a/Kernel/VM/Region.cpp +++ b/Kernel/VM/Region.cpp @@ -562,18 +562,7 @@ PageFaultResponse Region::handle_inode_fault(size_t page_index_in_region) } u8* dest_ptr = MM.quickmap_page(*vmobject_physical_page_entry); - { - void* fault_at; - if (!safe_memcpy(dest_ptr, page_buffer, PAGE_SIZE, fault_at)) { - if ((u8*)fault_at >= dest_ptr && (u8*)fault_at <= dest_ptr + PAGE_SIZE) - dbgln(" >> inode fault: error copying data to {}/{}, failed at {}", - vmobject_physical_page_entry->paddr(), - VirtualAddress(dest_ptr), - VirtualAddress(fault_at)); - else - VERIFY_NOT_REACHED(); - } - } + memcpy(dest_ptr, page_buffer, PAGE_SIZE); MM.unquickmap_page(); remap_vmobject_page(page_index_in_vmobject);