RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:37:45 +00:00
Code Issues Activity Actions

3DFileViewer: Remove unnecessary tests when loading files

Browse source 
These tests are already performed by `LibFileSystemAccessClient`.
This commit is contained in:
Lucas CHOLLET 2023-01-14 19:06:33 -05:00 • committed by Sam Atkins
parent f9e3a591d2
commit 13b149b42e
1 changed files with 0 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Applications/3DFileViewer/main.cpp
View file

@ -308,16 +308,6 @@ bool GLContextWidget::load_file(Core::DeprecatedFile& file)
return false; return false;
} }
if (file.is_device()) {
GUI::MessageBox::show(window(), DeprecatedString::formatted("Opening \"{}\" failed: Can't open device files", filename), "Error"sv, GUI::MessageBox::Type::Error);
return false;
}
if (file.is_directory()) {
GUI::MessageBox::show(window(), DeprecatedString::formatted("Opening \"{}\" failed: Can't open directories", filename), "Error"sv, GUI::MessageBox::Type::Error);
return false;
}
auto new_mesh = m_mesh_loader->load(String::from_deprecated_string(file.filename()).release_value_but_fixme_should_propagate_errors(), auto new_mesh = m_mesh_loader->load(String::from_deprecated_string(file.filename()).release_value_but_fixme_should_propagate_errors(),
Core::File::adopt_fd(file.leak_fd(), Core::File::OpenMode::Read).release_value_but_fixme_should_propagate_errors()); Core::File::adopt_fd(file.leak_fd(), Core::File::OpenMode::Read).release_value_but_fixme_should_propagate_errors());
if (new_mesh.is_error()) { if (new_mesh.is_error()) {