RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:18:11 +00:00
Code Issues Activity Actions

LibJS: Use String and move semantics in Bytecode::StringTable

Browse source 
Avoid creating new AK::String objects when we already have one.
This commit is contained in:
Andreas Kling 2021-10-24 15:14:14 +02:00
parent 3117182c2e
commit 13f04e37e5
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Bytecode/Generator.h
View file

@ -97,9 +97,9 @@ public:
return m_current_basic_block->is_terminated(); return m_current_basic_block->is_terminated();
} }
StringTableIndex intern_string(StringView const& string) StringTableIndex intern_string(String string)
{ {
return m_string_table->insert(string); return m_string_table->insert(move(string));
} }
bool is_in_generator_function() const { return m_is_in_generator_function; } bool is_in_generator_function() const { return m_is_in_generator_function; }

4
Userland/Libraries/LibJS/Bytecode/StringTable.cpp
View file

@ -8,13 +8,13 @@
namespace JS::Bytecode { namespace JS::Bytecode {
StringTableIndex StringTable::insert(StringView string) StringTableIndex StringTable::insert(String string)
{ {
for (size_t i = 0; i < m_strings.size(); i++) { for (size_t i = 0; i < m_strings.size(); i++) {
if (m_strings[i] == string) if (m_strings[i] == string)
return i; return i;
} }
m_strings.append(string); m_strings.append(move(string));
return m_strings.size() - 1; return m_strings.size() - 1;
} }

2
Userland/Libraries/LibJS/Bytecode/StringTable.h
View file

@ -21,7 +21,7 @@ class StringTable {
public: public:
StringTable() = default; StringTable() = default;
StringTableIndex insert(StringView string); StringTableIndex insert(String);
String const& get(StringTableIndex) const; String const& get(StringTableIndex) const;
void dump() const; void dump() const;
bool is_empty() const { return m_strings.is_empty(); } bool is_empty() const { return m_strings.is_empty(); }