RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 22:57:44 +00:00
Code Issues Activity Actions

LibWeb: Include anonymous boxes with no lines into computing BFC height

Browse source 
Pseudo-elements like ::before and ::after were discarded when their
content property was an empty string (ignoring whitespace), because they
are anonymous containers with no lines.

Our previous way around it was to add an empty line box (see b062a0fb7c)
however it didn't actually work for cases described in the previous
commit.

This makes avatars and cover arts square on last.fm and "fixes" the test
css-pseudo-element-should-not-be-affected-by-presentational-hints.html.
Unfortunately, this also regresses on block-and-inline/clearfix.html,
but that hopefully will be handled in subsequent commit.
This commit is contained in:
Karol Kosek 2023-07-11 12:21:59 +02:00 • committed by Andreas Kling
parent d4b5205482
commit 142d498f14
7 changed files with 37 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Tests/LibWeb/Layout/expected/pseudo-element-with-custom-properties-2.txt
View file

@ -9,12 +9,9 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BreakNode <br>
TextNode <#text>
BlockContainer <div.a> at (8,29.828125) content-size 784x100 children: inline
line 0 width: 200, height: 100, bottom: 100, baseline: 16.890625
line 0 width: 200, height: 100, bottom: 100, baseline: 100
frag 0 from BlockContainer start: 0, length: 0, rect: [8,29.828125 200x100]
BlockContainer <(anonymous)> at (8,29.828125) content-size 200x100 inline-block [BFC] children: inline
line 0 width: 0, height: 21.828125, bottom: 21.828125, baseline: 16.890625
frag 0 from TextNode start: 0, length: 0, rect: [8,29.828125 0x21.828125]
""
TextNode <#text>
BlockContainer <(anonymous)> at (8,129.828125) content-size 784x65.484375 children: inline
line 0 width: 0, height: 21.828125, bottom: 21.828125, baseline: 16.890625
@ -29,12 +26,9 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BreakNode <br>
TextNode <#text>
BlockContainer <div.b> at (8,195.3125) content-size 784x100 children: inline
line 0 width: 200, height: 100, bottom: 100, baseline: 16.890625
line 0 width: 200, height: 100, bottom: 100, baseline: 100
frag 0 from BlockContainer start: 0, length: 0, rect: [8,195.3125 200x100]
BlockContainer <(anonymous)> at (8,195.3125) content-size 200x100 inline-block [BFC] children: inline
line 0 width: 0, height: 21.828125, bottom: 21.828125, baseline: 16.890625
frag 0 from TextNode start: 0, length: 0, rect: [8,195.3125 0x21.828125]
""
TextNode <#text>
BlockContainer <(anonymous)> at (8,295.3125) content-size 784x65.484375 children: inline
line 0 width: 0, height: 21.828125, bottom: 21.828125, baseline: 16.890625
@ -49,12 +43,9 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BreakNode <br>
TextNode <#text>
BlockContainer <div.c> at (8,360.796875) content-size 784x100 children: inline
line 0 width: 200, height: 100, bottom: 100, baseline: 16.890625
line 0 width: 200, height: 100, bottom: 100, baseline: 100
frag 0 from BlockContainer start: 0, length: 0, rect: [8,360.796875 200x100]
BlockContainer <(anonymous)> at (8,360.796875) content-size 200x100 inline-block [BFC] children: inline
line 0 width: 0, height: 21.828125, bottom: 21.828125, baseline: 16.890625
frag 0 from TextNode start: 0, length: 0, rect: [8,360.796875 0x21.828125]
""
TextNode <#text>
BlockContainer <(anonymous)> at (8,460.796875) content-size 784x0 children: inline
TextNode <#text>