RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 10:07:44 +00:00
Code Issues Activity Actions

LibGfx: Make Gfx::Bitmap::set_nonvolatile() report allocation failure

Browse source 
Making a bitmap non-volatile after being volatile may fail to allocate
physical pages after the kernel stole the old pages in a purge.

This is different from the pages being purged, but reallocated. In that
case, they are simply replaced with zero-fill-on-demand pages as if
they were freshly allocated.
This commit is contained in:
Andreas Kling 2021-07-24 22:49:48 +02:00
parent 24b5295b30
commit 143443e0b6
23 changed files with 57 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibGfx/Bitmap.h
View file

@ -227,7 +227,10 @@ public:
[[nodiscard]] bool is_volatile() const { return m_volatile; }
void set_volatile();
[[nodiscard]] bool set_nonvolatile();
// Returns true if making the bitmap non-volatile succeeded. `was_purged` indicates status of contents.
// Returns false if there was not enough memory.
[[nodiscard]] bool set_nonvolatile(bool& was_purged);
[[nodiscard]] Core::AnonymousBuffer& anonymous_buffer() { return m_buffer; }
[[nodiscard]] Core::AnonymousBuffer const& anonymous_buffer() const { return m_buffer; }