RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 11:57:35 +00:00
Code Issues Activity Actions

LibJS: Propagate errors from TypedArray for_each_item{,_from_last} calls

Browse source 
Another mistake uncovered by moving away from manual exception checks
and relying on correct completion types instead :^)
This commit is contained in:
Linus Groh 2022-01-03 21:54:44 +01:00
parent 913511249b
commit 143465b23a
1 changed files with 14 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.cpp
View file

@ -201,13 +201,13 @@ JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::at)
JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::every) JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::every)
{ {
auto result = true; auto result = true;
for_each_item(vm, global_object, "every", [&](auto, auto, auto callback_result) { TRY(for_each_item(vm, global_object, "every", [&](auto, auto, auto callback_result) {
if (!callback_result.to_boolean()) { if (!callback_result.to_boolean()) {
result = false; result = false;
return IterationDecision::Break; return IterationDecision::Break;
} }
return IterationDecision::Continue; return IterationDecision::Continue;
}); }));
return Value(result); return Value(result);
} }
@ -261,13 +261,13 @@ JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::fill)
JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::find) JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::find)
{ {
auto result = js_undefined(); auto result = js_undefined();
for_each_item(vm, global_object, "find", [&](auto, auto value, auto callback_result) { TRY(for_each_item(vm, global_object, "find", [&](auto, auto value, auto callback_result) {
if (callback_result.to_boolean()) { if (callback_result.to_boolean()) {
result = value; result = value;
return IterationDecision::Break; return IterationDecision::Break;
} }
return IterationDecision::Continue; return IterationDecision::Continue;
}); }));
return result; return result;
} }
@ -275,13 +275,13 @@ JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::find)
JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::find_index) JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::find_index)
{ {
auto result_index = -1; auto result_index = -1;
for_each_item(vm, global_object, "findIndex", [&](auto index, auto, auto callback_result) { TRY(for_each_item(vm, global_object, "findIndex", [&](auto index, auto, auto callback_result) {
if (callback_result.to_boolean()) { if (callback_result.to_boolean()) {
result_index = index; result_index = index;
return IterationDecision::Break; return IterationDecision::Break;
} }
return IterationDecision::Continue; return IterationDecision::Continue;
}); }));
return Value(result_index); return Value(result_index);
} }
@ -289,13 +289,13 @@ JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::find_index)
JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::find_last) JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::find_last)
{ {
auto result = js_undefined(); auto result = js_undefined();
for_each_item_from_last(vm, global_object, "findLast", [&](auto, auto value, auto callback_result) { TRY(for_each_item_from_last(vm, global_object, "findLast", [&](auto, auto value, auto callback_result) {
if (callback_result.to_boolean()) { if (callback_result.to_boolean()) {
result = value; result = value;
return IterationDecision::Break; return IterationDecision::Break;
} }
return IterationDecision::Continue; return IterationDecision::Continue;
}); }));
return result; return result;
} }
@ -303,22 +303,22 @@ JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::find_last)
JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::find_last_index) JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::find_last_index)
{ {
auto result_index = -1; auto result_index = -1;
for_each_item_from_last(vm, global_object, "findLastIndex", [&](auto index, auto, auto callback_result) { TRY(for_each_item_from_last(vm, global_object, "findLastIndex", [&](auto index, auto, auto callback_result) {
if (callback_result.to_boolean()) { if (callback_result.to_boolean()) {
result_index = index; result_index = index;
return IterationDecision::Break; return IterationDecision::Break;
} }
return IterationDecision::Continue; return IterationDecision::Continue;
}); }));
return Value(result_index); return Value(result_index);
} }
// 23.2.3.13 %TypedArray%.prototype.forEach ( callbackfn [ , thisArg ] ), https://tc39.es/ecma262/#sec-%typedarray%.prototype.foreach // 23.2.3.13 %TypedArray%.prototype.forEach ( callbackfn [ , thisArg ] ), https://tc39.es/ecma262/#sec-%typedarray%.prototype.foreach
JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::for_each) JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::for_each)
{ {
for_each_item(vm, global_object, "forEach", [](auto, auto, auto) { TRY(for_each_item(vm, global_object, "forEach", [](auto, auto, auto) {
return IterationDecision::Continue; return IterationDecision::Continue;
}); }));
return js_undefined(); return js_undefined();
} }
@ -510,13 +510,13 @@ JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::reduce_right)
JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::some) JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::some)
{ {
auto result = false; auto result = false;
for_each_item(vm, global_object, "some", [&](auto, auto, auto callback_result) { TRY(for_each_item(vm, global_object, "some", [&](auto, auto, auto callback_result) {
if (callback_result.to_boolean()) { if (callback_result.to_boolean()) {
result = true; result = true;
return IterationDecision::Break; return IterationDecision::Break;
} }
return IterationDecision::Continue; return IterationDecision::Continue;
}); }));
return Value(result); return Value(result);
} }