RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:17:44 +00:00
Code Issues Activity Actions

FontEditor: Sanitize RTL and control glyphs in Clipboard metadata

Browse source 
Fixes display issues in ClipboardHistory.
This commit is contained in:
thankyouverycool 2021-09-21 17:43:29 -04:00 • committed by Andreas Kling
parent 0a4640e892
commit 144d32d537
1 changed files with 7 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Userland/Applications/FontEditor/GlyphEditorWidget.cpp
View file

@ -6,6 +6,7 @@
#include "GlyphEditorWidget.h" #include "GlyphEditorWidget.h"
#include <AK/StringBuilder.h> #include <AK/StringBuilder.h>
#include <AK/UnicodeUtils.h>
#include <LibGUI/Clipboard.h> #include <LibGUI/Clipboard.h>
#include <LibGUI/Painter.h> #include <LibGUI/Painter.h>
#include <LibGfx/BitmapFont.h> #include <LibGfx/BitmapFont.h>
@ -65,15 +66,12 @@ void GlyphEditorWidget::copy_glyph()
} }
StringBuilder glyph_builder; StringBuilder glyph_builder;
if (m_glyph < 128) { if (AK::UnicodeUtils::is_unicode_control_code_point(m_glyph))
if (m_glyph == 10) glyph_builder.append(AK::UnicodeUtils::get_unicode_control_code_point_alias(m_glyph).value());
glyph_builder.append("LF"); else if (Gfx::get_char_bidi_class(m_glyph) == Gfx::BidirectionalClass::STRONG_RTL)
else glyph_builder.append_code_point(0xFFFD);
glyph_builder.append(m_glyph); else
} else { glyph_builder.append_code_point(m_glyph);
glyph_builder.append(128 | 64 | (m_glyph / 64));
glyph_builder.append(128 | (m_glyph % 64));
}
HashMap<String, String> metadata; HashMap<String, String> metadata;
metadata.set("char", glyph_builder.to_string()); metadata.set("char", glyph_builder.to_string());