diff --git a/Kernel/Process.h b/Kernel/Process.h index f9e04a7fc1..f9ed74368f 100644 --- a/Kernel/Process.h +++ b/Kernel/Process.h @@ -1037,10 +1037,10 @@ inline ProcessID Thread::pid() const } #define VERIFY_PROCESS_BIG_LOCK_ACQUIRED(process) \ - VERIFY(process->big_lock().is_exclusively_locked_by_current_thread()); + VERIFY(process->big_lock().is_exclusively_locked_by_current_thread()) #define VERIFY_NO_PROCESS_BIG_LOCK(process) \ - VERIFY(!process->big_lock().is_exclusively_locked_by_current_thread()); + VERIFY(!process->big_lock().is_exclusively_locked_by_current_thread()) inline static ErrorOr> try_copy_kstring_from_user(Kernel::Syscall::StringArgument const& string) { diff --git a/Kernel/Syscalls/getuid.cpp b/Kernel/Syscalls/getuid.cpp index 0b2d48aa8a..b166453661 100644 --- a/Kernel/Syscalls/getuid.cpp +++ b/Kernel/Syscalls/getuid.cpp @@ -10,35 +10,35 @@ namespace Kernel { ErrorOr Process::sys$getuid() { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); return uid().value(); } ErrorOr Process::sys$getgid() { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); return gid().value(); } ErrorOr Process::sys$geteuid() { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); return euid().value(); } ErrorOr Process::sys$getegid() { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); return egid().value(); } ErrorOr Process::sys$getresuid(Userspace ruid, Userspace euid, Userspace suid) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); TRY(copy_to_user(ruid, &m_protected_values.uid)); TRY(copy_to_user(euid, &m_protected_values.euid)); @@ -48,7 +48,7 @@ ErrorOr Process::sys$getresuid(Userspace ruid, Userspace Process::sys$getresgid(Userspace rgid, Userspace egid, Userspace sgid) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); TRY(copy_to_user(rgid, &m_protected_values.gid)); TRY(copy_to_user(egid, &m_protected_values.egid)); @@ -58,7 +58,7 @@ ErrorOr Process::sys$getresgid(Userspace rgid, Userspace Process::sys$getgroups(size_t count, Userspace user_gids) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); if (!count) return extra_gids().size(); diff --git a/Kernel/Syscalls/hostname.cpp b/Kernel/Syscalls/hostname.cpp index 3733ee438b..fdc74d86a6 100644 --- a/Kernel/Syscalls/hostname.cpp +++ b/Kernel/Syscalls/hostname.cpp @@ -10,7 +10,7 @@ namespace Kernel { ErrorOr Process::sys$gethostname(Userspace buffer, size_t size) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::stdio)); if (size > NumericLimits::max()) return EINVAL; @@ -24,7 +24,7 @@ ErrorOr Process::sys$gethostname(Userspace buffer, size_t size) ErrorOr Process::sys$sethostname(Userspace buffer, size_t length) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_no_promises()); if (!is_superuser()) diff --git a/Kernel/Syscalls/inode_watcher.cpp b/Kernel/Syscalls/inode_watcher.cpp index cff0a82b71..2ff70ca498 100644 --- a/Kernel/Syscalls/inode_watcher.cpp +++ b/Kernel/Syscalls/inode_watcher.cpp @@ -15,7 +15,7 @@ namespace Kernel { ErrorOr Process::sys$create_inode_watcher(u32 flags) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::rpath)); auto fd_allocation = TRY(allocate_fd()); @@ -38,7 +38,7 @@ ErrorOr Process::sys$create_inode_watcher(u32 flags) ErrorOr Process::sys$inode_watcher_add_watch(Userspace user_params) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::rpath)); auto params = TRY(copy_typed_from_user(user_params)); @@ -56,7 +56,7 @@ ErrorOr Process::sys$inode_watcher_add_watch(Userspace Process::sys$inode_watcher_remove_watch(int fd, int wd) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); auto description = TRY(open_file_description(fd)); if (!description->is_inode_watcher()) return EBADF; diff --git a/Kernel/Syscalls/ioctl.cpp b/Kernel/Syscalls/ioctl.cpp index ccbe9d7681..029fe9d53f 100644 --- a/Kernel/Syscalls/ioctl.cpp +++ b/Kernel/Syscalls/ioctl.cpp @@ -13,7 +13,7 @@ namespace Kernel { ErrorOr Process::sys$ioctl(int fd, unsigned request, FlatPtr arg) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); auto description = TRY(open_file_description(fd)); if (request == FIONBIO) { description->set_blocking(TRY(copy_typed_from_user(Userspace(arg))) == 0); diff --git a/Kernel/Syscalls/kill.cpp b/Kernel/Syscalls/kill.cpp index 58c3409b5d..2314610381 100644 --- a/Kernel/Syscalls/kill.cpp +++ b/Kernel/Syscalls/kill.cpp @@ -97,7 +97,7 @@ ErrorOr Process::do_killself(int signal) ErrorOr Process::sys$kill(pid_t pid_or_pgid, int signal) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); if (pid_or_pgid == pid().value()) TRY(require_promise(Pledge::stdio)); else @@ -129,7 +129,7 @@ ErrorOr Process::sys$kill(pid_t pid_or_pgid, int signal) ErrorOr Process::sys$killpg(pid_t pgrp, int signum) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::proc)); if (signum < 1 || signum >= 32) return EINVAL; diff --git a/Kernel/Syscalls/link.cpp b/Kernel/Syscalls/link.cpp index fea3c69f00..19da805cb1 100644 --- a/Kernel/Syscalls/link.cpp +++ b/Kernel/Syscalls/link.cpp @@ -12,7 +12,7 @@ namespace Kernel { ErrorOr Process::sys$link(Userspace user_params) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::cpath)); auto params = TRY(copy_typed_from_user(user_params)); auto old_path = TRY(try_copy_kstring_from_user(params.old_path)); @@ -23,7 +23,7 @@ ErrorOr Process::sys$link(Userspace use ErrorOr Process::sys$symlink(Userspace user_params) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::cpath)); auto params = TRY(copy_typed_from_user(user_params)); diff --git a/Kernel/Syscalls/mkdir.cpp b/Kernel/Syscalls/mkdir.cpp index dca3fa39e1..46451a6f3c 100644 --- a/Kernel/Syscalls/mkdir.cpp +++ b/Kernel/Syscalls/mkdir.cpp @@ -12,7 +12,7 @@ namespace Kernel { ErrorOr Process::sys$mkdir(Userspace user_path, size_t path_length, mode_t mode) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::cpath)); auto path = TRY(get_syscall_path_argument(user_path, path_length)); TRY(VirtualFileSystem::the().mkdir(path->view(), mode & ~umask(), current_directory())); diff --git a/Kernel/Syscalls/mknod.cpp b/Kernel/Syscalls/mknod.cpp index fed155c4df..ba07f2142b 100644 --- a/Kernel/Syscalls/mknod.cpp +++ b/Kernel/Syscalls/mknod.cpp @@ -12,7 +12,7 @@ namespace Kernel { ErrorOr Process::sys$mknod(Userspace user_params) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::dpath)); auto params = TRY(copy_typed_from_user(user_params)); diff --git a/Kernel/Syscalls/mmap.cpp b/Kernel/Syscalls/mmap.cpp index eb7f9b5490..928700f5e1 100644 --- a/Kernel/Syscalls/mmap.cpp +++ b/Kernel/Syscalls/mmap.cpp @@ -127,7 +127,7 @@ ErrorOr Process::validate_inode_mmap_prot(int prot, Inode const& inode, bo ErrorOr Process::sys$mmap(Userspace user_params) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); auto params = TRY(copy_typed_from_user(user_params)); @@ -250,7 +250,7 @@ ErrorOr Process::sys$mmap(Userspace use ErrorOr Process::sys$mprotect(Userspace addr, size_t size, int prot) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); if (prot & PROT_EXEC) { @@ -379,7 +379,7 @@ ErrorOr Process::sys$mprotect(Userspace addr, size_t size, int p ErrorOr Process::sys$madvise(Userspace address, size_t size, int advice) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); auto range_to_madvise = TRY(Memory::expand_range_to_page_boundaries(address.ptr(), size)); @@ -410,7 +410,7 @@ ErrorOr Process::sys$madvise(Userspace address, size_t size, int ErrorOr Process::sys$set_mmap_name(Userspace user_params) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); auto params = TRY(copy_typed_from_user(user_params)); @@ -434,7 +434,7 @@ ErrorOr Process::sys$set_mmap_name(Userspace Process::sys$munmap(Userspace addr, size_t size) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); TRY(address_space().unmap_mmap_range(addr.vaddr(), size)); return 0; @@ -442,7 +442,7 @@ ErrorOr Process::sys$munmap(Userspace addr, size_t size) ErrorOr Process::sys$mremap(Userspace user_params) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); auto params = TRY(copy_typed_from_user(user_params)); @@ -478,7 +478,7 @@ ErrorOr Process::sys$mremap(Userspace ErrorOr Process::sys$allocate_tls(Userspace initial_data, size_t size) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); if (!size || size % PAGE_SIZE != 0) @@ -532,7 +532,7 @@ ErrorOr Process::sys$allocate_tls(Userspace initial_data, ErrorOr Process::sys$msyscall(Userspace address) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); if (address_space().enforces_syscall_regions()) return EPERM; diff --git a/Kernel/Syscalls/mount.cpp b/Kernel/Syscalls/mount.cpp index ecf4894b5d..0a78956619 100644 --- a/Kernel/Syscalls/mount.cpp +++ b/Kernel/Syscalls/mount.cpp @@ -68,7 +68,7 @@ static ErrorOr> create_filesystem_instance(StringView ErrorOr Process::sys$mount(Userspace user_params) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_no_promises()); if (!is_superuser()) return EPERM; @@ -125,7 +125,7 @@ ErrorOr Process::sys$mount(Userspace u ErrorOr Process::sys$umount(Userspace user_mountpoint, size_t mountpoint_length) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); if (!is_superuser()) return EPERM; diff --git a/Kernel/Syscalls/open.cpp b/Kernel/Syscalls/open.cpp index c8e7797f66..04b8c43443 100644 --- a/Kernel/Syscalls/open.cpp +++ b/Kernel/Syscalls/open.cpp @@ -15,7 +15,7 @@ namespace Kernel { ErrorOr Process::sys$open(Userspace user_params) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); auto params = TRY(copy_typed_from_user(user_params)); int dirfd = params.dirfd; @@ -80,7 +80,7 @@ ErrorOr Process::sys$open(Userspace use ErrorOr Process::sys$close(int fd) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::stdio)); auto description = TRY(open_file_description(fd)); auto result = description->close(); diff --git a/Kernel/Syscalls/perf_event.cpp b/Kernel/Syscalls/perf_event.cpp index f7da35d5d9..bde0e260d6 100644 --- a/Kernel/Syscalls/perf_event.cpp +++ b/Kernel/Syscalls/perf_event.cpp @@ -11,7 +11,7 @@ namespace Kernel { ErrorOr Process::sys$perf_event(int type, FlatPtr arg1, FlatPtr arg2) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); auto* events_buffer = current_perf_events_buffer(); if (!events_buffer) return 0; @@ -21,7 +21,7 @@ ErrorOr Process::sys$perf_event(int type, FlatPtr arg1, FlatPtr arg2) ErrorOr Process::sys$perf_register_string(Userspace user_string, size_t user_string_length) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); auto* events_buffer = current_perf_events_buffer(); if (!events_buffer) return 0; diff --git a/Kernel/Syscalls/pipe.cpp b/Kernel/Syscalls/pipe.cpp index e6b8e90879..7cdb0829df 100644 --- a/Kernel/Syscalls/pipe.cpp +++ b/Kernel/Syscalls/pipe.cpp @@ -11,7 +11,7 @@ namespace Kernel { ErrorOr Process::sys$pipe(Userspace pipefd, int flags) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::stdio)); // Reject flags other than O_CLOEXEC, O_NONBLOCK diff --git a/Kernel/Syscalls/pledge.cpp b/Kernel/Syscalls/pledge.cpp index c6b7fc5ec0..c32399bba9 100644 --- a/Kernel/Syscalls/pledge.cpp +++ b/Kernel/Syscalls/pledge.cpp @@ -11,7 +11,7 @@ namespace Kernel { ErrorOr Process::sys$pledge(Userspace user_params) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); auto params = TRY(copy_typed_from_user(user_params)); if (params.promises.length > 1024 || params.execpromises.length > 1024) diff --git a/Kernel/Syscalls/poll.cpp b/Kernel/Syscalls/poll.cpp index 731540b0f5..68d963ef7b 100644 --- a/Kernel/Syscalls/poll.cpp +++ b/Kernel/Syscalls/poll.cpp @@ -16,7 +16,7 @@ using BlockFlags = Thread::FileBlocker::BlockFlags; ErrorOr Process::sys$poll(Userspace user_params) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); auto params = TRY(copy_typed_from_user(user_params)); diff --git a/Kernel/Syscalls/prctl.cpp b/Kernel/Syscalls/prctl.cpp index 5d7d69d236..c9a5cab73a 100644 --- a/Kernel/Syscalls/prctl.cpp +++ b/Kernel/Syscalls/prctl.cpp @@ -11,7 +11,7 @@ namespace Kernel { ErrorOr Process::sys$prctl(int option, FlatPtr arg1, [[maybe_unused]] FlatPtr arg2) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); switch (option) { case PR_GET_DUMPABLE: return is_dumpable(); diff --git a/Kernel/Syscalls/process.cpp b/Kernel/Syscalls/process.cpp index cd7bafc721..209098ce6c 100644 --- a/Kernel/Syscalls/process.cpp +++ b/Kernel/Syscalls/process.cpp @@ -11,21 +11,21 @@ namespace Kernel { ErrorOr Process::sys$getpid() { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::stdio)); return pid().value(); } ErrorOr Process::sys$getppid() { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); return m_protected_values.ppid.value(); } ErrorOr Process::sys$get_process_name(Userspace buffer, size_t buffer_size) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); if (m_name->length() + 1 > buffer_size) return ENAMETOOLONG; @@ -36,7 +36,7 @@ ErrorOr Process::sys$get_process_name(Userspace buffer, size_t b ErrorOr Process::sys$set_process_name(Userspace user_name, size_t user_name_length) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::proc)); if (user_name_length > 256) return ENAMETOOLONG; @@ -50,7 +50,7 @@ ErrorOr Process::sys$set_process_name(Userspace user_name, ErrorOr Process::sys$set_coredump_metadata(Userspace user_params) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); auto params = TRY(copy_typed_from_user(user_params)); if (params.key.length == 0 || params.key.length > 16 * KiB) diff --git a/Kernel/Syscalls/profiling.cpp b/Kernel/Syscalls/profiling.cpp index 1671f185ff..c2c298085b 100644 --- a/Kernel/Syscalls/profiling.cpp +++ b/Kernel/Syscalls/profiling.cpp @@ -20,7 +20,7 @@ u64 g_profiling_event_mask; // does not fit into a register on 32bit architectures. ErrorOr Process::sys$profiling_enable(pid_t pid, Userspace userspace_event_mask) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_no_promises()); auto const event_mask = TRY(copy_typed_from_user(userspace_event_mask)); @@ -77,7 +77,7 @@ ErrorOr Process::sys$profiling_enable(pid_t pid, Userspace ErrorOr Process::sys$profiling_disable(pid_t pid) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_no_promises()); if (pid == -1) { @@ -107,7 +107,7 @@ ErrorOr Process::sys$profiling_disable(pid_t pid) ErrorOr Process::sys$profiling_free_buffer(pid_t pid) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_no_promises()); if (pid == -1) { diff --git a/Kernel/Syscalls/ptrace.cpp b/Kernel/Syscalls/ptrace.cpp index bca30d428a..13fdea073f 100644 --- a/Kernel/Syscalls/ptrace.cpp +++ b/Kernel/Syscalls/ptrace.cpp @@ -158,7 +158,7 @@ static ErrorOr handle_ptrace(Kernel::Syscall::SC_ptrace_params const& p ErrorOr Process::sys$ptrace(Userspace user_params) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::ptrace)); auto params = TRY(copy_typed_from_user(user_params)); diff --git a/Kernel/Syscalls/purge.cpp b/Kernel/Syscalls/purge.cpp index e690a79df5..e241aa3605 100644 --- a/Kernel/Syscalls/purge.cpp +++ b/Kernel/Syscalls/purge.cpp @@ -14,7 +14,7 @@ namespace Kernel { ErrorOr Process::sys$purge(int mode) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_no_promises()); if (!is_superuser()) return EPERM; diff --git a/Kernel/Syscalls/read.cpp b/Kernel/Syscalls/read.cpp index 4392e1f5d9..06253ce9ab 100644 --- a/Kernel/Syscalls/read.cpp +++ b/Kernel/Syscalls/read.cpp @@ -40,7 +40,7 @@ static ErrorOr check_blocked_read(OpenFileDescription* description) ErrorOr Process::sys$readv(int fd, Userspace iov, int iov_count) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); if (iov_count < 0) return EINVAL; @@ -87,7 +87,7 @@ ErrorOr Process::sys$read(int fd, Userspace buffer, size_t size) ErrorOr Process::read_impl(int fd, Userspace buffer, size_t size) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); if (size == 0) return 0; @@ -105,7 +105,7 @@ ErrorOr Process::read_impl(int fd, Userspace buffer, size_t size) // hence it can't be passed by register on 32bit platforms. ErrorOr Process::sys$pread(int fd, Userspace buffer, size_t size, Userspace userspace_offset) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); if (size == 0) return 0; diff --git a/Kernel/Syscalls/rename.cpp b/Kernel/Syscalls/rename.cpp index d1ff77672f..8da237d1dd 100644 --- a/Kernel/Syscalls/rename.cpp +++ b/Kernel/Syscalls/rename.cpp @@ -12,7 +12,7 @@ namespace Kernel { ErrorOr Process::sys$rename(Userspace user_params) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::cpath)); auto params = TRY(copy_typed_from_user(user_params)); auto old_path = TRY(get_syscall_path_argument(params.old_path)); diff --git a/Kernel/Syscalls/resource.cpp b/Kernel/Syscalls/resource.cpp index 0349ae804f..97b130efc2 100644 --- a/Kernel/Syscalls/resource.cpp +++ b/Kernel/Syscalls/resource.cpp @@ -10,7 +10,7 @@ namespace Kernel { ErrorOr Process::sys$getrusage(int who, Userspace user_usage) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); rusage usage {}; diff --git a/Kernel/Syscalls/rmdir.cpp b/Kernel/Syscalls/rmdir.cpp index 32f943f0c4..0db5ee57f1 100644 --- a/Kernel/Syscalls/rmdir.cpp +++ b/Kernel/Syscalls/rmdir.cpp @@ -12,7 +12,7 @@ namespace Kernel { ErrorOr Process::sys$rmdir(Userspace user_path, size_t path_length) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::cpath)); auto path = TRY(get_syscall_path_argument(user_path, path_length)); TRY(VirtualFileSystem::the().rmdir(path->view(), current_directory())); diff --git a/Kernel/Syscalls/sched.cpp b/Kernel/Syscalls/sched.cpp index 2f5d007cba..92814e9caf 100644 --- a/Kernel/Syscalls/sched.cpp +++ b/Kernel/Syscalls/sched.cpp @@ -19,7 +19,7 @@ ErrorOr Process::sys$yield() ErrorOr Process::sys$sched_setparam(int pid, Userspace user_param) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::proc)); auto param = TRY(copy_typed_from_user(user_param)); @@ -43,7 +43,7 @@ ErrorOr Process::sys$sched_setparam(int pid, Userspace Process::sys$sched_getparam(pid_t pid, Userspace user_param) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::proc)); int priority; { diff --git a/Kernel/Syscalls/sendfd.cpp b/Kernel/Syscalls/sendfd.cpp index 6b306c2433..254e0aa827 100644 --- a/Kernel/Syscalls/sendfd.cpp +++ b/Kernel/Syscalls/sendfd.cpp @@ -12,7 +12,7 @@ namespace Kernel { ErrorOr Process::sys$sendfd(int sockfd, int fd) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::sendfd)); auto socket_description = TRY(open_file_description(sockfd)); if (!socket_description->is_socket()) @@ -31,7 +31,7 @@ ErrorOr Process::sys$sendfd(int sockfd, int fd) ErrorOr Process::sys$recvfd(int sockfd, int options) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::recvfd)); auto socket_description = TRY(open_file_description(sockfd)); if (!socket_description->is_socket()) diff --git a/Kernel/Syscalls/setpgid.cpp b/Kernel/Syscalls/setpgid.cpp index d2976c9aa5..92dbc681ba 100644 --- a/Kernel/Syscalls/setpgid.cpp +++ b/Kernel/Syscalls/setpgid.cpp @@ -12,7 +12,7 @@ namespace Kernel { ErrorOr Process::sys$getsid(pid_t pid) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::proc)); if (pid == 0) return sid().value(); @@ -26,7 +26,7 @@ ErrorOr Process::sys$getsid(pid_t pid) ErrorOr Process::sys$setsid() { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::proc)); InterruptDisabler disabler; bool found_process_with_same_pgid_as_my_pid = false; @@ -47,7 +47,7 @@ ErrorOr Process::sys$setsid() ErrorOr Process::sys$getpgid(pid_t pid) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::proc)); if (pid == 0) return pgid().value(); @@ -59,7 +59,7 @@ ErrorOr Process::sys$getpgid(pid_t pid) ErrorOr Process::sys$getpgrp() { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); return pgid().value(); } @@ -79,7 +79,7 @@ SessionID Process::get_sid_from_pgid(ProcessGroupID pgid) ErrorOr Process::sys$setpgid(pid_t specified_pid, pid_t specified_pgid) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::proc)); ProcessID pid = specified_pid ? ProcessID(specified_pid) : this->pid(); if (specified_pgid < 0) { diff --git a/Kernel/Syscalls/setuid.cpp b/Kernel/Syscalls/setuid.cpp index 38dadfeaf5..1e726f499e 100644 --- a/Kernel/Syscalls/setuid.cpp +++ b/Kernel/Syscalls/setuid.cpp @@ -10,7 +10,7 @@ namespace Kernel { ErrorOr Process::sys$seteuid(UserID new_euid) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::id)); if (new_euid == (uid_t)-1) @@ -30,7 +30,7 @@ ErrorOr Process::sys$seteuid(UserID new_euid) ErrorOr Process::sys$setegid(GroupID new_egid) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::id)); if (new_egid == (uid_t)-1) @@ -49,7 +49,7 @@ ErrorOr Process::sys$setegid(GroupID new_egid) ErrorOr Process::sys$setuid(UserID new_uid) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::id)); if (new_uid == (uid_t)-1) @@ -70,7 +70,7 @@ ErrorOr Process::sys$setuid(UserID new_uid) ErrorOr Process::sys$setgid(GroupID new_gid) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::id)); if (new_gid == (uid_t)-1) @@ -91,7 +91,7 @@ ErrorOr Process::sys$setgid(GroupID new_gid) ErrorOr Process::sys$setreuid(UserID new_ruid, UserID new_euid) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::id)); if (new_ruid == (uid_t)-1) @@ -117,7 +117,7 @@ ErrorOr Process::sys$setreuid(UserID new_ruid, UserID new_euid) ErrorOr Process::sys$setresuid(UserID new_ruid, UserID new_euid, UserID new_suid) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::id)); if (new_ruid == (uid_t)-1) @@ -143,7 +143,7 @@ ErrorOr Process::sys$setresuid(UserID new_ruid, UserID new_euid, UserID ErrorOr Process::sys$setresgid(GroupID new_rgid, GroupID new_egid, GroupID new_sgid) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::id)); if (new_rgid == (gid_t)-1) @@ -169,7 +169,7 @@ ErrorOr Process::sys$setresgid(GroupID new_rgid, GroupID new_egid, Grou ErrorOr Process::sys$setgroups(size_t count, Userspace user_gids) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::id)); if (!is_superuser()) return EPERM; diff --git a/Kernel/Syscalls/sigaction.cpp b/Kernel/Syscalls/sigaction.cpp index 32d69733fb..7c4b9488bf 100644 --- a/Kernel/Syscalls/sigaction.cpp +++ b/Kernel/Syscalls/sigaction.cpp @@ -13,7 +13,7 @@ namespace Kernel { ErrorOr Process::sys$sigprocmask(int how, Userspace set, Userspace old_set) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::sigaction)); auto* current_thread = Thread::current(); u32 previous_signal_mask; @@ -43,7 +43,7 @@ ErrorOr Process::sys$sigprocmask(int how, Userspace se ErrorOr Process::sys$sigpending(Userspace set) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); auto pending_signals = Thread::current()->pending_signals(); TRY(copy_to_user(set, &pending_signals)); @@ -52,7 +52,7 @@ ErrorOr Process::sys$sigpending(Userspace set) ErrorOr Process::sys$sigaction(int signum, Userspace user_act, Userspace user_old_act) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::sigaction)); if (signum < 1 || signum >= NSIG || signum == SIGKILL || signum == SIGSTOP) return EINVAL; @@ -77,7 +77,7 @@ ErrorOr Process::sys$sigaction(int signum, Userspace ErrorOr Process::sys$sigreturn([[maybe_unused]] RegisterState& registers) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); SmapDisabler disabler; @@ -249,7 +249,7 @@ ErrorOr Process::remap_range_as_stack(FlatPtr address, size_t size) ErrorOr Process::sys$sigaltstack(Userspace user_ss, Userspace user_old_ss) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::sigaction)); if (user_old_ss) { @@ -298,7 +298,7 @@ ErrorOr Process::sys$sigaltstack(Userspace user_ss, Use // https://pubs.opengroup.org/onlinepubs/9699919799/functions/sigtimedwait.html ErrorOr Process::sys$sigtimedwait(Userspace set, Userspace info, Userspace timeout) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::sigaction)); sigset_t set_value; @@ -329,7 +329,7 @@ ErrorOr Process::sys$sigtimedwait(Userspace set, Users // https://pubs.opengroup.org/onlinepubs/9699919799/functions/sigsuspend.html ErrorOr Process::sys$sigsuspend(Userspace mask) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); auto sigmask = TRY(copy_typed_from_user(mask)); diff --git a/Kernel/Syscalls/socket.cpp b/Kernel/Syscalls/socket.cpp index 790ad9c6c3..fa9114a3d7 100644 --- a/Kernel/Syscalls/socket.cpp +++ b/Kernel/Syscalls/socket.cpp @@ -33,7 +33,7 @@ static void setup_socket_fd(Process::OpenFileDescriptions& fds, int fd, NonnullR ErrorOr Process::sys$socket(int domain, int type, int protocol) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); REQUIRE_PROMISE_FOR_SOCKET_DOMAIN(domain); if ((type & SOCK_TYPE_MASK) == SOCK_RAW && !is_superuser()) @@ -50,7 +50,7 @@ ErrorOr Process::sys$socket(int domain, int type, int protocol) ErrorOr Process::sys$bind(int sockfd, Userspace address, socklen_t address_length) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); auto description = TRY(open_file_description(sockfd)); if (!description->is_socket()) return ENOTSOCK; @@ -62,7 +62,7 @@ ErrorOr Process::sys$bind(int sockfd, Userspace addres ErrorOr Process::sys$listen(int sockfd, int backlog) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); if (backlog < 0) return EINVAL; auto description = TRY(open_file_description(sockfd)); @@ -78,7 +78,7 @@ ErrorOr Process::sys$listen(int sockfd, int backlog) ErrorOr Process::sys$accept4(Userspace user_params) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::accept)); auto params = TRY(copy_typed_from_user(user_params)); @@ -145,7 +145,7 @@ ErrorOr Process::sys$accept4(Userspace Process::sys$connect(int sockfd, Userspace user_address, socklen_t user_address_size) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); auto description = TRY(open_file_description(sockfd)); if (!description->is_socket()) @@ -158,7 +158,7 @@ ErrorOr Process::sys$connect(int sockfd, Userspace use ErrorOr Process::sys$shutdown(int sockfd, int how) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::stdio)); if (how != SHUT_RD && how != SHUT_WR && how != SHUT_RDWR) return EINVAL; @@ -173,7 +173,7 @@ ErrorOr Process::sys$shutdown(int sockfd, int how) ErrorOr Process::sys$sendmsg(int sockfd, Userspace user_msg, int flags) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); auto msg = TRY(copy_typed_from_user(user_msg)); @@ -218,7 +218,7 @@ ErrorOr Process::sys$sendmsg(int sockfd, Userspace Process::sys$recvmsg(int sockfd, Userspace user_msg, int flags) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); struct msghdr msg; @@ -308,7 +308,7 @@ ErrorOr Process::get_sock_or_peer_name(Params const& params) ErrorOr Process::sys$getsockname(Userspace user_params) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); auto params = TRY(copy_typed_from_user(user_params)); TRY(get_sock_or_peer_name(params)); return 0; @@ -316,7 +316,7 @@ ErrorOr Process::sys$getsockname(Userspace Process::sys$getpeername(Userspace user_params) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); auto params = TRY(copy_typed_from_user(user_params)); TRY(get_sock_or_peer_name(params)); return 0; @@ -324,7 +324,7 @@ ErrorOr Process::sys$getpeername(Userspace Process::sys$getsockopt(Userspace user_params) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); auto params = TRY(copy_typed_from_user(user_params)); int sockfd = params.sockfd; @@ -347,7 +347,7 @@ ErrorOr Process::sys$getsockopt(Userspace Process::sys$setsockopt(Userspace user_params) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); auto params = TRY(copy_typed_from_user(user_params)); Userspace user_value((FlatPtr)params.value); @@ -362,7 +362,7 @@ ErrorOr Process::sys$setsockopt(Userspace Process::sys$socketpair(Userspace user_params) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); auto params = TRY(copy_typed_from_user(user_params)); if (params.domain != AF_LOCAL) diff --git a/Kernel/Syscalls/statvfs.cpp b/Kernel/Syscalls/statvfs.cpp index ce22b6d856..856b0752bf 100644 --- a/Kernel/Syscalls/statvfs.cpp +++ b/Kernel/Syscalls/statvfs.cpp @@ -41,7 +41,7 @@ ErrorOr Process::do_statvfs(FileSystem const& fs, Custody const* custod ErrorOr Process::sys$statvfs(Userspace user_params) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::rpath)); auto params = TRY(copy_typed_from_user(user_params)); diff --git a/Kernel/Syscalls/sync.cpp b/Kernel/Syscalls/sync.cpp index 6557d4e86b..c3395977e0 100644 --- a/Kernel/Syscalls/sync.cpp +++ b/Kernel/Syscalls/sync.cpp @@ -11,7 +11,7 @@ namespace Kernel { ErrorOr Process::sys$sync() { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::stdio)); VirtualFileSystem::sync(); return 0; diff --git a/Kernel/Syscalls/sysconf.cpp b/Kernel/Syscalls/sysconf.cpp index b2cbd5e08c..0f471460ef 100644 --- a/Kernel/Syscalls/sysconf.cpp +++ b/Kernel/Syscalls/sysconf.cpp @@ -12,7 +12,7 @@ namespace Kernel { ErrorOr Process::sys$sysconf(int name) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); switch (name) { case _SC_MONOTONIC_CLOCK: return 1; diff --git a/Kernel/Syscalls/thread.cpp b/Kernel/Syscalls/thread.cpp index a1b21fa574..8f6c6b0d81 100644 --- a/Kernel/Syscalls/thread.cpp +++ b/Kernel/Syscalls/thread.cpp @@ -14,7 +14,7 @@ namespace Kernel { ErrorOr Process::sys$create_thread(void* (*entry)(void*), Userspace user_params) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::thread)); auto params = TRY(copy_typed_from_user(user_params)); @@ -74,7 +74,7 @@ ErrorOr Process::sys$create_thread(void* (*entry)(void*), Userspace exit_value, Userspace stack_location, size_t stack_size) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); auto result = require_promise(Pledge::thread); if (result.is_error()) { @@ -103,7 +103,7 @@ void Process::sys$exit_thread(Userspace exit_value, Userspace stac ErrorOr Process::sys$detach_thread(pid_t tid) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::thread)); auto thread = Thread::from_tid(tid); if (!thread || thread->pid() != pid()) @@ -118,7 +118,7 @@ ErrorOr Process::sys$detach_thread(pid_t tid) ErrorOr Process::sys$join_thread(pid_t tid, Userspace exit_value) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::thread)); auto thread = Thread::from_tid(tid); @@ -153,7 +153,7 @@ ErrorOr Process::sys$join_thread(pid_t tid, Userspace exit_valu ErrorOr Process::sys$kill_thread(pid_t tid, int signal) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::thread)); if (signal < 0 || signal >= NSIG) @@ -171,7 +171,7 @@ ErrorOr Process::sys$kill_thread(pid_t tid, int signal) ErrorOr Process::sys$set_thread_name(pid_t tid, Userspace user_name, size_t user_name_length) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); auto name = TRY(try_copy_kstring_from_user(user_name, user_name_length)); @@ -190,7 +190,7 @@ ErrorOr Process::sys$set_thread_name(pid_t tid, Userspace ErrorOr Process::sys$get_thread_name(pid_t tid, Userspace buffer, size_t buffer_size) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::thread)); if (buffer_size == 0) return EINVAL; @@ -217,7 +217,7 @@ ErrorOr Process::sys$get_thread_name(pid_t tid, Userspace buffer ErrorOr Process::sys$gettid() { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::stdio)); return Thread::current()->tid().value(); } diff --git a/Kernel/Syscalls/times.cpp b/Kernel/Syscalls/times.cpp index 54aa6b481d..300a531417 100644 --- a/Kernel/Syscalls/times.cpp +++ b/Kernel/Syscalls/times.cpp @@ -10,7 +10,7 @@ namespace Kernel { ErrorOr Process::sys$times(Userspace user_times) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); tms times = {}; times.tms_utime = m_ticks_in_user; diff --git a/Kernel/Syscalls/umask.cpp b/Kernel/Syscalls/umask.cpp index 6018984765..0ec8a97c3b 100644 --- a/Kernel/Syscalls/umask.cpp +++ b/Kernel/Syscalls/umask.cpp @@ -10,7 +10,7 @@ namespace Kernel { ErrorOr Process::sys$umask(mode_t mask) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); auto old_mask = m_protected_values.umask; ProtectedDataMutationScope scope { *this }; diff --git a/Kernel/Syscalls/uname.cpp b/Kernel/Syscalls/uname.cpp index dd6469fc36..7c8280c1c8 100644 --- a/Kernel/Syscalls/uname.cpp +++ b/Kernel/Syscalls/uname.cpp @@ -10,7 +10,7 @@ namespace Kernel { ErrorOr Process::sys$uname(Userspace user_buf) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::stdio)); utsname buf {}; diff --git a/Kernel/Syscalls/unlink.cpp b/Kernel/Syscalls/unlink.cpp index 582b1bea58..5f3a62330e 100644 --- a/Kernel/Syscalls/unlink.cpp +++ b/Kernel/Syscalls/unlink.cpp @@ -12,7 +12,7 @@ namespace Kernel { ErrorOr Process::sys$unlink(int dirfd, Userspace user_path, size_t path_length, int flags) { - VERIFY_NO_PROCESS_BIG_LOCK(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::cpath)); auto path = TRY(get_syscall_path_argument(user_path, path_length)); diff --git a/Kernel/Syscalls/unveil.cpp b/Kernel/Syscalls/unveil.cpp index 3db49b3a87..f1e8116451 100644 --- a/Kernel/Syscalls/unveil.cpp +++ b/Kernel/Syscalls/unveil.cpp @@ -26,7 +26,7 @@ static void update_intermediate_node_permissions(UnveilNode& root_node, UnveilAc ErrorOr Process::sys$unveil(Userspace user_params) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); auto params = TRY(copy_typed_from_user(user_params)); if (!params.path.characters && !params.permissions.characters) { diff --git a/Kernel/Syscalls/utime.cpp b/Kernel/Syscalls/utime.cpp index ad5918aaff..1e1bb4144f 100644 --- a/Kernel/Syscalls/utime.cpp +++ b/Kernel/Syscalls/utime.cpp @@ -12,7 +12,7 @@ namespace Kernel { ErrorOr Process::sys$utime(Userspace user_path, size_t path_length, Userspace user_buf) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::fattr)); auto path = TRY(get_syscall_path_argument(user_path, path_length)); utimbuf buf; diff --git a/Kernel/Syscalls/waitid.cpp b/Kernel/Syscalls/waitid.cpp index d204e82e73..ac3e7c500b 100644 --- a/Kernel/Syscalls/waitid.cpp +++ b/Kernel/Syscalls/waitid.cpp @@ -21,7 +21,7 @@ ErrorOr Process::do_waitid(Variant, Non ErrorOr Process::sys$waitid(Userspace user_params) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::proc)); auto params = TRY(copy_typed_from_user(user_params)); diff --git a/Kernel/Syscalls/write.cpp b/Kernel/Syscalls/write.cpp index d105761ffb..fef524bb75 100644 --- a/Kernel/Syscalls/write.cpp +++ b/Kernel/Syscalls/write.cpp @@ -13,7 +13,7 @@ namespace Kernel { ErrorOr Process::sys$writev(int fd, Userspace iov, int iov_count) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); if (iov_count < 0) return EINVAL; @@ -88,7 +88,7 @@ ErrorOr Process::do_write(OpenFileDescription& description, UserOrKerne ErrorOr Process::sys$write(int fd, Userspace data, size_t size) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); TRY(require_promise(Pledge::stdio)); if (size == 0) return 0;