RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:07:36 +00:00
Code Issues Activity Actions

LibWeb: Implement HTMLOrSVGElement.tabIndex

Browse source
This commit is contained in:
Luke Wilde 2022-11-05 03:58:14 +00:00 • committed by Andreas Kling
parent 6c21c72492
commit 1473bc9169
22 changed files with 119 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/AttributeNames.h
View file

@ -24,6 +24,7 @@ namespace AttributeNames {
__ENUMERATE_HTML_ATTRIBUTE(alt) \
__ENUMERATE_HTML_ATTRIBUTE(archive) \
__ENUMERATE_HTML_ATTRIBUTE(async) \
__ENUMERATE_HTML_ATTRIBUTE(autofocus) \
__ENUMERATE_HTML_ATTRIBUTE(autoplay) \
__ENUMERATE_HTML_ATTRIBUTE(axis) \
__ENUMERATE_HTML_ATTRIBUTE(background) \
@ -208,6 +209,7 @@ namespace AttributeNames {
__ENUMERATE_HTML_ATTRIBUTE(step) \
__ENUMERATE_HTML_ATTRIBUTE(style) \
__ENUMERATE_HTML_ATTRIBUTE(summary) \
__ENUMERATE_HTML_ATTRIBUTE(tabindex) \
__ENUMERATE_HTML_ATTRIBUTE(target) \
__ENUMERATE_HTML_ATTRIBUTE(text) \
__ENUMERATE_HTML_ATTRIBUTE(title) \

7
Userland/Libraries/LibWeb/HTML/HTMLAnchorElement.cpp
View file

@ -77,4 +77,11 @@ void HTMLAnchorElement::run_activation_behavior(Web::DOM::Event const&)
follow_the_hyperlink(hyperlink_suffix);
}
// https://html.spec.whatwg.org/multipage/interaction.html#dom-tabindex
i32 HTMLAnchorElement::default_tab_index_value() const
{
// See the base function for the spec comments.
return 0;
}
}

1
Userland/Libraries/LibWeb/HTML/HTMLAnchorElement.h
View file

@ -35,6 +35,7 @@ private:
// ^DOM::Element
virtual void parse_attribute(FlyString const& name, String const& value) override;
virtual i32 default_tab_index_value() const override;
// ^HTML::HTMLHyperlinkElementUtils
virtual DOM::Document& hyperlink_element_utils_document() override { return document(); }

7
Userland/Libraries/LibWeb/HTML/HTMLAreaElement.cpp
View file

@ -35,4 +35,11 @@ void HTMLAreaElement::set_hyperlink_element_utils_href(String href)
MUST(set_attribute(HTML::AttributeNames::href, move(href)));
}
// https://html.spec.whatwg.org/multipage/interaction.html#dom-tabindex
i32 HTMLAreaElement::default_tab_index_value() const
{
// See the base function for the spec comments.
return 0;
}
}

1
Userland/Libraries/LibWeb/HTML/HTMLAreaElement.h
View file

@ -25,6 +25,7 @@ private:
// ^DOM::Element
virtual void parse_attribute(FlyString const& name, String const& value) override;
virtual i32 default_tab_index_value() const override;
// ^HTML::HTMLHyperlinkElementUtils
virtual DOM::Document& hyperlink_element_utils_document() override { return document(); }

7
Userland/Libraries/LibWeb/HTML/HTMLButtonElement.cpp
View file

@ -86,4 +86,11 @@ void HTMLButtonElement::set_type(String const& type)
MUST(set_attribute(HTML::AttributeNames::type, type));
}
// https://html.spec.whatwg.org/multipage/interaction.html#dom-tabindex
i32 HTMLButtonElement::default_tab_index_value() const
{
// See the base function for the spec comments.
return 0;
}
}

3
Userland/Libraries/LibWeb/HTML/HTMLButtonElement.h
View file

@ -55,6 +55,9 @@ public:
private:
HTMLButtonElement(DOM::Document&, DOM::QualifiedName);
// ^DOM::Element
virtual i32 default_tab_index_value() const override;
};
}

2
Userland/Libraries/LibWeb/HTML/HTMLElement.idl
View file

@ -32,4 +32,6 @@ HTMLElement includes HTMLOrSVGElement;
interface mixin HTMLOrSVGElement {
[SameObject] readonly attribute DOMStringMap dataset;
[CEReactions] attribute long tabIndex;
};

8
Userland/Libraries/LibWeb/HTML/HTMLFrameElement.cpp
View file

@ -16,4 +16,12 @@ HTMLFrameElement::HTMLFrameElement(DOM::Document& document, DOM::QualifiedName q
}
HTMLFrameElement::~HTMLFrameElement() = default;
// https://html.spec.whatwg.org/multipage/interaction.html#dom-tabindex
i32 HTMLFrameElement::default_tab_index_value() const
{
// See the base function for the spec comments.
return 0;
}
}

2
Userland/Libraries/LibWeb/HTML/HTMLFrameElement.h
View file

@ -19,6 +19,8 @@ public:
private:
HTMLFrameElement(DOM::Document&, DOM::QualifiedName);
// ^DOM::Element
virtual i32 default_tab_index_value() const override;
};
}

7
Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.cpp
View file

@ -164,4 +164,11 @@ void run_iframe_load_event_steps(HTML::HTMLIFrameElement& element)
// FIXME: 6. Unset childDocument's iframe load in progress flag.
}
// https://html.spec.whatwg.org/multipage/interaction.html#dom-tabindex
i32 HTMLIFrameElement::default_tab_index_value() const
{
// See the base function for the spec comments.
return 0;
}
}

2
Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.h
View file

@ -28,9 +28,11 @@ public:
private:
HTMLIFrameElement(DOM::Document&, DOM::QualifiedName);
// ^DOM::Element
virtual void inserted() override;
virtual void removed_from(Node*) override;
virtual void parse_attribute(FlyString const& name, String const& value) override;
virtual i32 default_tab_index_value() const override;
// https://html.spec.whatwg.org/multipage/iframe-embed-object.html#process-the-iframe-attributes
void process_the_iframe_attributes(bool initial_insertion = false);

7
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -555,4 +555,11 @@ void HTMLInputElement::legacy_cancelled_activation_behavior_was_not_called()
m_legacy_pre_activation_behavior_checked_element_in_group = nullptr;
}
// https://html.spec.whatwg.org/multipage/interaction.html#dom-tabindex
i32 HTMLInputElement::default_tab_index_value() const
{
// See the base function for the spec comments.
return 0;
}
}

3
Userland/Libraries/LibWeb/HTML/HTMLInputElement.h
View file

@ -123,6 +123,9 @@ private:
virtual void legacy_cancelled_activation_behavior() override;
virtual void legacy_cancelled_activation_behavior_was_not_called() override;
// ^DOM::Element
virtual i32 default_tab_index_value() const override;
virtual void visit_edges(Cell::Visitor&) override;
static TypeAttributeState parse_type_attribute(StringView);

7
Userland/Libraries/LibWeb/HTML/HTMLObjectElement.cpp
View file

@ -316,4 +316,11 @@ void HTMLObjectElement::update_layout_and_child_objects(Representation represent
document().set_needs_layout();
}
// https://html.spec.whatwg.org/multipage/interaction.html#dom-tabindex
i32 HTMLObjectElement::default_tab_index_value() const
{
// See the base function for the spec comments.
return 0;
}
}

3
Userland/Libraries/LibWeb/HTML/HTMLObjectElement.h
View file

@ -62,6 +62,9 @@ private:
virtual void resource_did_load() override;
virtual void resource_did_fail() override;
// ^DOM::Element
virtual i32 default_tab_index_value() const override;
Representation m_representation { Representation::Unknown };
Optional<ImageLoader> m_image_loader;
};

7
Userland/Libraries/LibWeb/HTML/HTMLSelectElement.cpp
View file

@ -122,4 +122,11 @@ void HTMLSelectElement::set_selected_index(int index)
selected_option->m_dirty = true;
}
// https://html.spec.whatwg.org/multipage/interaction.html#dom-tabindex
i32 HTMLSelectElement::default_tab_index_value() const
{
// See the base function for the spec comments.
return 0;
}
}

3
Userland/Libraries/LibWeb/HTML/HTMLSelectElement.h
View file

@ -61,6 +61,9 @@ private:
virtual void visit_edges(Cell::Visitor&) override;
// ^DOM::Element
virtual i32 default_tab_index_value() const override;
JS::GCPtr<HTMLOptionsCollection> m_options;
};

7
Userland/Libraries/LibWeb/HTML/HTMLTextAreaElement.cpp
View file

@ -17,4 +17,11 @@ HTMLTextAreaElement::HTMLTextAreaElement(DOM::Document& document, DOM::Qualified
HTMLTextAreaElement::~HTMLTextAreaElement() = default;
// https://html.spec.whatwg.org/multipage/interaction.html#dom-tabindex
i32 HTMLTextAreaElement::default_tab_index_value() const
{
// See the base function for the spec comments.
return 0;
}
}

3
Userland/Libraries/LibWeb/HTML/HTMLTextAreaElement.h
View file

@ -50,6 +50,9 @@ public:
private:
HTMLTextAreaElement(DOM::Document&, DOM::QualifiedName);
// ^DOM::Element
virtual i32 default_tab_index_value() const override;
};
}