From 1474b18070b92bafec3cb1dd8ffef9f26aa17ca1 Mon Sep 17 00:00:00 2001 From: Idan Horowitz Date: Sat, 9 Apr 2022 23:05:32 +0300 Subject: [PATCH] Kernel: Remove big lock from sys$link This syscall doesn't access any unprotected shared data. --- Kernel/API/Syscall.h | 2 +- Kernel/Syscalls/link.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Kernel/API/Syscall.h b/Kernel/API/Syscall.h index b6150dea75..14093bfd4a 100644 --- a/Kernel/API/Syscall.h +++ b/Kernel/API/Syscall.h @@ -109,7 +109,7 @@ enum class NeedsBigProcessLock { S(kill, NeedsBigProcessLock::Yes) \ S(kill_thread, NeedsBigProcessLock::Yes) \ S(killpg, NeedsBigProcessLock::Yes) \ - S(link, NeedsBigProcessLock::Yes) \ + S(link, NeedsBigProcessLock::No) \ S(listen, NeedsBigProcessLock::No) \ S(lseek, NeedsBigProcessLock::No) \ S(madvise, NeedsBigProcessLock::Yes) \ diff --git a/Kernel/Syscalls/link.cpp b/Kernel/Syscalls/link.cpp index a2b23589d1..48a937568c 100644 --- a/Kernel/Syscalls/link.cpp +++ b/Kernel/Syscalls/link.cpp @@ -12,7 +12,7 @@ namespace Kernel { ErrorOr Process::sys$link(Userspace user_params) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_NO_PROCESS_BIG_LOCK(this) TRY(require_promise(Pledge::cpath)); auto params = TRY(copy_typed_from_user(user_params)); auto old_path = TRY(try_copy_kstring_from_user(params.old_path));