mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 21:27:35 +00:00
SoundPlayer: Fix stack-use-after-scope when playing file in loop mode
The path returned by GUI:FilePicker is stored on the stack when the callback is executed. The player only stored a StringView to the path however it should take ownership of the path instead since the path is accessed even after the file menu open action has returned.
This commit is contained in:
parent
1e48cd35a1
commit
1476f02f99
2 changed files with 4 additions and 4 deletions
|
@ -38,7 +38,7 @@ Player::Player(Audio::ClientConnection& audio_client_connection)
|
|||
};
|
||||
}
|
||||
|
||||
void Player::play_file_path(StringView path)
|
||||
void Player::play_file_path(String const& path)
|
||||
{
|
||||
if (path.is_null())
|
||||
return;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue