RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:37:47 +00:00
Code Issues Activity Actions

SoundPlayer: Fix stack-use-after-scope when playing file in loop mode

Browse source 
The path returned by GUI:FilePicker is stored on the stack when the
callback is executed. The player only stored a StringView to the path
however it should take ownership of the path instead since the path is
accessed even after the file menu open action has returned.
This commit is contained in:
Simon Woertz 2021-11-07 16:22:12 +01:00 • committed by Brian Gianforcaro
parent 1e48cd35a1
commit 1476f02f99
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Applications/SoundPlayer/Player.h
View file

@ -32,10 +32,10 @@ public:
explicit Player(Audio::ClientConnection& audio_client_connection);
virtual ~Player() { }
void play_file_path(StringView path);
void play_file_path(String const& path);
Playlist& playlist() { return m_playlist; }
StringView loaded_filename() const { return m_loaded_filename; }
String const& loaded_filename() const { return m_loaded_filename; }
PlayState play_state() const { return m_play_state; }
void set_play_state(PlayState);
@ -84,6 +84,6 @@ private:
Audio::ClientConnection& m_audio_client_connection;
PlaybackManager m_playback_manager;
StringView m_loaded_filename;
String m_loaded_filename;
double m_volume { 0 };
};