RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 13:32:45 +00:00
Code Issues Activity Actions

LibWeb: Flexbox: Catch zero flex-basis and use width instead

Browse source 
A flex-basis of zero doesn't actually mean that the preferred size of
the particular Box is 0. It means that the Box should take the least
amount of space possible while still accomodating the content inside.

We catch and circumvent this now right when the flex-basis property gets
read for the FlexFormattingContext.

This isn't mentioned anywhere in the seemingly relevant portions of the
spec, however thanks to this answer https://stackoverflow.com/a/47579078
(which is not entirely correct about width either) lead to the behavior
that is wanted and used by other Browsers.
This commit is contained in:
Tobias Christiansen 2021-10-01 20:10:19 +02:00 • committed by Andreas Kling
parent d426edb87f
commit 1496ad0605
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Libraries/LibWeb/Layout/FlexFormattingContext.cpp
View file

@ -365,7 +365,11 @@ void FlexFormattingContext::run(Box& box, LayoutMode)
auto flex_basis = child_box.computed_values().flex_basis();
if (flex_basis.type == CSS::FlexBasis::Length) {
// A
flex_item.flex_base_size = get_pixel_size(child_box, flex_basis.length);
auto specified_base_size = get_pixel_size(child_box, flex_basis.length);
if (specified_base_size == 0)
flex_item.flex_base_size = calculated_main_size(flex_item.box);
else
flex_item.flex_base_size = specified_base_size;
} else if (flex_basis.type == CSS::FlexBasis::Content
&& has_definite_cross_size(child_box)
// FIXME: && has intrinsic aspect ratio.
@ -504,12 +508,9 @@ void FlexFormattingContext::run(Box& box, LayoutMode)
for (auto& flex_item : flex_line.items) {
if (flex_item->flex_factor.has_value() && flex_item->flex_factor.value() == 0) {
freeze_item_setting_target_main_size_to_hypothetical_main_size(*flex_item);
} else if (flex_item->flex_factor.has_value()) {
// FIXME: This isn't spec
continue;
} else if (used_flex_factor == FlexFactor::FlexGrowFactor) {
// FIXME: Spec doesn't include the == case, but we take a too basic approach to calculating the values used so this is appropriate
if (flex_item->flex_base_size >= flex_item->hypothetical_main_size) {
if (flex_item->flex_base_size > flex_item->hypothetical_main_size) {
freeze_item_setting_target_main_size_to_hypothetical_main_size(*flex_item);
}
} else if (used_flex_factor == FlexFactor::FlexShrinkFactor) {