From 14aca0316130abc0b7b1b9ac2ed5ddcdbc8ae7e1 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Mon, 15 Nov 2021 11:38:23 -0500 Subject: [PATCH] LibJS: Remove FIXME comment from PartitionNotationSubPattern AO All possible patterns generated by LibUnicode are now handled. We have a similar VERIFY_NOT_REACHED in PartitionNumberPattern. --- Userland/Libraries/LibJS/Runtime/Intl/NumberFormat.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibJS/Runtime/Intl/NumberFormat.cpp b/Userland/Libraries/LibJS/Runtime/Intl/NumberFormat.cpp index a74c229f63..db7d2f715f 100644 --- a/Userland/Libraries/LibJS/Runtime/Intl/NumberFormat.cpp +++ b/Userland/Libraries/LibJS/Runtime/Intl/NumberFormat.cpp @@ -992,7 +992,8 @@ Vector partition_notation_sub_pattern(NumberFormat& number_for // 1. Let unknown be an ILND String based on x and p. // 2. Append a new Record { [[Type]]: "unknown", [[Value]]: unknown } as the last element of result. - // FIXME: Implement this when GetNotationSubPattern is fully implemented. + // LibUnicode doesn't generate any "unknown" patterns. + VERIFY_NOT_REACHED(); } } }