RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:17:34 +00:00
Code Issues Activity Actions

HackStudio: Use String instead of LexicalPath

Browse source 
LexicalPath is a 'heavier' object than a String that is mainly used for
path parsing and validation, we don't actually need any of that in
GitRepo and its related files, so let's move to String :^)

I've also done some east-const conversion in the files that I was
editing for the string change.
This commit is contained in:
Conor Byrne 2021-12-31 18:18:08 +00:00 • committed by Andreas Kling
parent 4cfc992125
commit 14b2656107
11 changed files with 79 additions and 77 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/DevTools/HackStudio/EditorWrapper.h
View file

@ -43,8 +43,8 @@ public:
void set_filename(const String&);
const String& filename() const { return m_filename; }
Optional<LexicalPath> const& project_root() const { return m_project_root; }
void set_project_root(LexicalPath const& project_root);
Optional<String> const& project_root() const { return m_project_root; }
void set_project_root(String const& project_root);
GitRepo const* git_repo() const { return m_git_repo; }
@ -64,7 +64,7 @@ private:
RefPtr<GUI::Label> m_filename_label;
RefPtr<Editor> m_editor;
Optional<LexicalPath> m_project_root;
Optional<String> m_project_root;
RefPtr<GitRepo> m_git_repo;
Vector<Diff::Hunk> m_hunks;
};