RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:37:37 +00:00
Code Issues Activity Actions

Kernel: Make module_load() and module_unload() be superuser-only

Browse source 
These should just fail with EPERM if you're not the superuser.
This commit is contained in:
Andreas Kling 2020-01-01 00:45:03 +01:00
parent 6af301edec
commit 14cdd3fdc1
1 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/Process.cpp
View file

@ -3695,10 +3695,8 @@ int Process::sys$beep()
int Process::sys$module_load(const char* path, size_t path_length) int Process::sys$module_load(const char* path, size_t path_length)
{ {
#if 0
if (!is_superuser()) if (!is_superuser())
return -EPERM; return -EPERM;
#endif
if (!validate_read(path, path_length)) if (!validate_read(path, path_length))
return -EFAULT; return -EFAULT;
auto description_or_error = VFS::the().open(path, 0, 0, current_directory()); auto description_or_error = VFS::the().open(path, 0, 0, current_directory());
@ -3814,10 +3812,8 @@ int Process::sys$module_load(const char* path, size_t path_length)
int Process::sys$module_unload(const char* name, size_t name_length) int Process::sys$module_unload(const char* name, size_t name_length)
{ {
#if 0
if (!is_superuser()) if (!is_superuser())
return -EPERM; return -EPERM;
#endif
if (!validate_read(name, name_length)) if (!validate_read(name, name_length))
return -EFAULT; return -EFAULT;