From 14eb736e22c6558941078716c528e5c037545d6e Mon Sep 17 00:00:00 2001 From: Brian Gianforcaro Date: Wed, 15 Sep 2021 23:22:56 -0700 Subject: [PATCH] AK: Reduce the scope of fraction_string to where it's needed pvs-studio flagged this a potential optimization, as we only need to really construct the fraction_string if is_double is true. --- AK/JsonParser.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AK/JsonParser.cpp b/AK/JsonParser.cpp index 4d497cb1b5..fafb6736a6 100644 --- a/AK/JsonParser.cpp +++ b/AK/JsonParser.cpp @@ -234,7 +234,6 @@ Optional JsonParser::parse_number() } StringView number_string(number_buffer.data(), number_buffer.size()); - StringView fraction_string(fraction_buffer.data(), fraction_buffer.size()); #ifndef KERNEL if (is_double) { @@ -250,6 +249,7 @@ Optional JsonParser::parse_number() whole = number.value(); } + StringView fraction_string(fraction_buffer.data(), fraction_buffer.size()); auto fraction_string_uint = fraction_string.to_uint(); if (!fraction_string_uint.has_value()) return {};