RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:47:46 +00:00
Code Issues Activity Actions

Endian: constexpr constructors and conversion operators

Browse source 
Problem:
- Constructors and conversion operators are not `constexpr`,
  but they can be.
- `constexpr` is needed here so that other classes can add `constexpr`
  evaluation.

Solution:
- Add the `constexpr` keyword to the constructors and
  conversion operators.
- Add `static_assert` tests which ensure the capability works.
This commit is contained in:
Lenny Maiorani 2020-10-08 09:38:31 -04:00 • committed by Andreas Kling
parent e8da5f99b1
commit 151b8b5984
2 changed files with 47 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
AK/Endian.h
View file

@ -32,7 +32,7 @@
namespace AK {
template<typename T>
ALWAYS_INLINE T convert_between_host_and_little_endian(T value)
ALWAYS_INLINE constexpr T convert_between_host_and_little_endian(T value)
{
#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
return value;
@ -49,7 +49,7 @@ ALWAYS_INLINE T convert_between_host_and_little_endian(T value)
}
template<typename T>
ALWAYS_INLINE T convert_between_host_and_big_endian(T value)
ALWAYS_INLINE constexpr T convert_between_host_and_big_endian(T value)
{
#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
if constexpr (sizeof(T) == 8)
@ -87,14 +87,14 @@ public:
friend InputStream& operator>><T>(InputStream&, LittleEndian<T>&);
friend OutputStream& operator<<<T>(OutputStream&, LittleEndian<T>);
LittleEndian() { }
constexpr LittleEndian() { }
LittleEndian(T value)
constexpr LittleEndian(T value)
: m_value(convert_between_host_and_little_endian(value))
{
}
operator T() const { return convert_between_host_and_little_endian(m_value); }
constexpr operator T() const { return convert_between_host_and_little_endian(m_value); }
private:
T m_value { 0 };
@ -116,14 +116,14 @@ public:
friend InputStream& operator>><T>(InputStream&, BigEndian<T>&);
friend OutputStream& operator<<<T>(OutputStream&, BigEndian<T>);
BigEndian() { }
constexpr BigEndian() = default;
BigEndian(T value)
constexpr BigEndian(T value)
: m_value(convert_between_host_and_big_endian(value))
{
}
operator T() const { return convert_between_host_and_big_endian(m_value); }
constexpr operator T() const { return convert_between_host_and_big_endian(m_value); }
private:
T m_value { 0 };