RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 23:57:44 +00:00
Code Issues Activity Actions

LibWeb: Avoid leaking infinite remaining_free_space in FFC calculation

Browse source 
After switching to fixed-point arithmetic in CSSPixels, it no longer
supports representing infinite values, which was previously the case
for remaining_free_space in FFC. Using Optional that is not empty only
when value is finite to store remaining_free_space ensures that
infinity is avoided in layout calculations.
This commit is contained in:
Aliaksandr Kalenik 2023-07-25 22:18:08 +02:00 • committed by Andreas Kling
parent de95a2fe33
commit 152ce88984
4 changed files with 36 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Tests/LibWeb/Layout/expected/flex/inf-available-space-with-auto-margins.txt Normal file
View file

@ -0,0 +1,8 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x33.46875 [BFC] children: not-inline
Box <body> at (8,8) content-size 784x17.46875 flex-container(column) [FFC] children: not-inline
BlockContainer <main> at (8,8) content-size 784x17.46875 flex-item [BFC] children: inline
line 0 width: 153.984375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 13, rect: [8,8 153.984375x17.46875]
"hmmMMMMmmmmmm"
TextNode <#text>

10
Tests/LibWeb/Layout/input/flex/inf-available-space-with-auto-margins.html Normal file
View file

@ -0,0 +1,10 @@
<!DOCTYPE html><html><head><style>
body {
display: flex;
flex-direction: column;
}
main {
margin-top: auto;
margin-bottom: auto;
}
</style></head><body><main>hmmMMMMmmmmmm