RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 21:57:34 +00:00
Code Issues Activity Actions

LibWeb: Ignore flex container size constraints during intrinsic sizing

Browse source 
Properties like min-width, max-width, etc, should be ignored while we're
trying to determine the intrinsic size of a flex container.

This fixes an infinite recursion when using an intrinsic size keyword as
the max-width of a flex column container.

Note that this behavior is marked as AD-HOC in code comments because
specs don't tell us how to achieve intrinsic sizing.

We can now load product pages on the Twinings site, such as
https://twinings.co.uk/products/earl-grey-100-tea-bags :^)
This commit is contained in:
Andreas Kling 2023-08-01 18:32:08 +02:00
parent f6e4caf197
commit 15440b156f
3 changed files with 23 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Tests/LibWeb/Layout/expected/flex/flex-column-container-with-max-width-max-content.txt Normal file
View file

@ -0,0 +1,3 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x16 [BFC] children: not-inline
Box <body> at (8,8) content-size 0x0 flex-container(column) [FFC] children: not-inline