RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:58:11 +00:00
Code Issues Activity Actions

LibJS: Make Value::as_object() return Object&

Browse source 
Let's move towards using references over pointers in LibJS as well.
I had originally steered away from it because that's how I've seen
things done in other engines. But this is not the other engines. :^)
This commit is contained in:
Andreas Kling 2020-04-01 22:18:47 +02:00
parent b995a499d3
commit 1549c5c48b
8 changed files with 54 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Libraries/LibJS/Runtime/Object.cpp
View file

@ -56,8 +56,8 @@ bool Object::has_prototype(const Object* prototype) const
Optional<Value> Object::get_own_property(const Object& this_object, const FlyString& property_name) const
{
auto value_here = m_properties.get(property_name);
if (value_here.has_value() && value_here.value().is_object() && value_here.value().as_object()->is_native_property()) {
auto& native_property = static_cast<const NativeProperty&>(*value_here.value().as_object());
if (value_here.has_value() && value_here.value().is_object() && value_here.value().as_object().is_native_property()) {
auto& native_property = static_cast<const NativeProperty&>(value_here.value().as_object());
auto& interpreter = const_cast<Object*>(this)->interpreter();
auto& call_frame = interpreter.push_call_frame();
call_frame.this_value = const_cast<Object*>(&this_object);
@ -71,8 +71,8 @@ Optional<Value> Object::get_own_property(const Object& this_object, const FlyStr
bool Object::put_own_property(Object& this_object, const FlyString& property_name, Value value)
{
auto value_here = m_properties.get(property_name);
if (value_here.has_value() && value_here.value().is_object() && value_here.value().as_object()->is_native_property()) {
auto& native_property = static_cast<NativeProperty&>(*value_here.value().as_object());
if (value_here.has_value() && value_here.value().is_object() && value_here.value().as_object().is_native_property()) {
auto& native_property = static_cast<NativeProperty&>(value_here.value().as_object());
auto& interpreter = const_cast<Object*>(this)->interpreter();
auto& call_frame = interpreter.push_call_frame();
call_frame.this_value = &this_object;
@ -103,8 +103,8 @@ void Object::put(const FlyString& property_name, Value value)
while (object) {
auto value_here = object->m_properties.get(property_name);
if (value_here.has_value()) {
if (value_here.value().is_object() && value_here.value().as_object()->is_native_property()) {
auto& native_property = static_cast<NativeProperty&>(*value_here.value().as_object());
if (value_here.value().is_object() && value_here.value().as_object().is_native_property()) {
auto& native_property = static_cast<NativeProperty&>(value_here.value().as_object());
auto& interpreter = const_cast<Object*>(this)->interpreter();
auto& call_frame = interpreter.push_call_frame();
call_frame.this_value = this;