RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 13:37:44 +00:00
Code Issues Activity Actions

LibWeb: Clamp scroll offset to valid range in set_scroll_offset()

Browse source 
By moving scroll offset clamp from `PaintableBox::scroll_by()` to
`PaintableBox::set_scroll_offset()`, we ensure that updates from
`Element::set_scroll_top()` and `Element::set_scroll_left()` are
constrained to a valid range.
This commit is contained in:
Aliaksandr Kalenik 2024-02-22 01:27:21 +01:00 • committed by Andreas Kling
parent ee4abacde6
commit 155070cfd8
3 changed files with 48 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

36
Tests/LibWeb/Text/input/DOM/Element-set-scroll-left.html Normal file
View file

@ -0,0 +1,36 @@
<style>
.scrollable-div {
width: 100%;
overflow-x: auto;
white-space: nowrap;
border: 10px magenta solid;
}
span {
width: 100px;
height: 100px;
display: inline-block;
border: 10px solid #000;
}
body {
width: 300px;
}
</style>
<body>
<div class="scrollable-div">
<span>Item 1</span><span>Item 2</span><span>Item 3</span><span>Item 4</span
><span>Item 5</span><span>Item 6</span><span>Item 7</span><span>Item 8</span
><span>Item 9</span><span>Item 10</span><span>Item 11</span><span>Item 12</span>
</div>
</body>
<script src="../include.js"></script>
<script>
test(() => {
const scrollableDiv = document.querySelector(".scrollable-div");
const scrollWidth = scrollableDiv.scrollWidth;
println("scrollWidth: " + scrollWidth);
scrollableDiv.scrollLeft = scrollableDiv.scrollWidth;
println("scrollLeft: " + scrollableDiv.scrollLeft);
});
</script>