RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:17:44 +00:00
Code Issues Activity Actions

LibHTML: Move is_ancestor_of() from LayoutNode to TreeNode

Browse source 
This way it becomes available to all the different TreeNode subclasses.
This commit is contained in:
Andreas Kling 2019-10-09 21:33:34 +02:00
parent fdbad6284c
commit 159507f2a6
2 changed files with 13 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibHTML/Layout/LayoutNode.h
View file

@ -81,8 +81,6 @@ public:
void set_needs_display(); void set_needs_display();
bool is_ancestor_of(const LayoutNode&) const;
template<typename Callback> template<typename Callback>
void for_each_fragment_of_this(Callback); void for_each_fragment_of_this(Callback);
@ -130,12 +128,3 @@ inline const LayoutNodeWithStyle* LayoutNode::parent() const
{ {
return static_cast<const LayoutNodeWithStyle*>(TreeNode<LayoutNode>::parent()); return static_cast<const LayoutNodeWithStyle*>(TreeNode<LayoutNode>::parent());
} }
inline bool LayoutNode::is_ancestor_of(const LayoutNode& other) const
{
for (auto* ancestor = other.parent(); ancestor; ancestor = ancestor->parent()) {
if (ancestor == this)
return true;
}
return false;
}

13
Libraries/LibHTML/TreeNode.h
View file

@ -33,6 +33,8 @@ public:
const T* first_child() const { return m_first_child; } const T* first_child() const { return m_first_child; }
const T* last_child() const { return m_last_child; } const T* last_child() const { return m_last_child; }
bool is_ancestor_of(const TreeNode&) const;
void prepend_child(NonnullRefPtr<T> node, bool call_inserted_into = true); void prepend_child(NonnullRefPtr<T> node, bool call_inserted_into = true);
void append_child(NonnullRefPtr<T> node, bool call_inserted_into = true); void append_child(NonnullRefPtr<T> node, bool call_inserted_into = true);
void donate_all_children_to(T& node); void donate_all_children_to(T& node);
@ -98,3 +100,14 @@ inline void TreeNode<T>::donate_all_children_to(T& node)
m_first_child = nullptr; m_first_child = nullptr;
m_last_child = nullptr; m_last_child = nullptr;
} }
template<typename T>
inline bool TreeNode<T>::is_ancestor_of(const TreeNode<T>& other) const
{
for (auto* ancestor = other.parent(); ancestor; ancestor = ancestor->parent()) {
if (ancestor == this)
return true;
}
return false;
}