RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:38:10 +00:00
Code Issues Activity Actions

LibJS: Put roundTo argument into a variable

Browse source 
Following the pattern we have in other protoypes to avoid a magic
number index into the zeroth argument.
This commit is contained in:
Shannon Booth 2024-02-18 14:34:58 +13:00 • committed by Tim Flynn
parent b7f80e7081
commit 15977ea42f
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp
View file

@ -326,12 +326,14 @@ JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::round)
{ {
auto& realm = *vm.current_realm(); auto& realm = *vm.current_realm();
auto round_to_value = vm.argument(0);
// 1. Let duration be the this value. // 1. Let duration be the this value.
// 2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]). // 2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]).
auto duration = TRY(typed_this_object(vm)); auto duration = TRY(typed_this_object(vm));
// 3. If roundTo is undefined, then // 3. If roundTo is undefined, then
if (vm.argument(0).is_undefined()) { if (round_to_value.is_undefined()) {
// a. Throw a TypeError exception. // a. Throw a TypeError exception.
return vm.throw_completion<TypeError>(ErrorType::TemporalMissingOptionsObject); return vm.throw_completion<TypeError>(ErrorType::TemporalMissingOptionsObject);
} }
@ -339,7 +341,7 @@ JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::round)
Object* round_to; Object* round_to;
// 4. If Type(roundTo) is String, then // 4. If Type(roundTo) is String, then
if (vm.argument(0).is_string()) { if (round_to_value.is_string()) {
// a. Let paramString be roundTo. // a. Let paramString be roundTo.
// b. Set roundTo to OrdinaryObjectCreate(null). // b. Set roundTo to OrdinaryObjectCreate(null).
@ -351,7 +353,7 @@ JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::round)
// 5. Else, // 5. Else,
else { else {
// a. Set roundTo to ? GetOptionsObject(roundTo). // a. Set roundTo to ? GetOptionsObject(roundTo).
round_to = TRY(get_options_object(vm, vm.argument(0))); round_to = TRY(get_options_object(vm, round_to_value));
} }
// 6. Let smallestUnitPresent be true. // 6. Let smallestUnitPresent be true.