RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 01:47:34 +00:00
Code Issues Activity Actions

Kernel: No need to check is_superuser() after may_execute().

Browse source 
Since may_execute() incorporates a superuser check. :^)
This commit is contained in:
Andreas Kling 2019-03-03 12:34:54 +01:00
parent 5e40aa4f1a
commit 159fa99539
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/VirtualFileSystem.cpp
View file

@ -295,7 +295,7 @@ KResultOr<Retained<Inode>> VFS::open_directory(const String& path, Inode& base)
auto inode = inode_or_error.value(); auto inode = inode_or_error.value();
if (!inode->is_directory()) if (!inode->is_directory())
return KResult(-ENOTDIR); return KResult(-ENOTDIR);
if (!inode->metadata().may_execute(*current) && !current->is_superuser()) if (!inode->metadata().may_execute(*current))
return KResult(-EACCES); return KResult(-EACCES);
return Retained<Inode>(*inode); return Retained<Inode>(*inode);
} }
@ -589,7 +589,7 @@ KResultOr<InodeIdentifier> VFS::resolve_path(const String& path, InodeIdentifier
#endif #endif
return KResult(-ENOTDIR); return KResult(-ENOTDIR);
} }
if (!metadata.may_execute(*current) && !current->is_superuser()) if (!metadata.may_execute(*current))
return KResult(-EACCES); return KResult(-EACCES);
auto parent = crumb_id; auto parent = crumb_id;
crumb_id = crumb_inode->lookup(part); crumb_id = crumb_inode->lookup(part);