diff --git a/Userland/DevTools/UserspaceEmulator/Emulator.cpp b/Userland/DevTools/UserspaceEmulator/Emulator.cpp index 85005bd349..49fbc01dd1 100644 --- a/Userland/DevTools/UserspaceEmulator/Emulator.cpp +++ b/Userland/DevTools/UserspaceEmulator/Emulator.cpp @@ -102,14 +102,14 @@ void Emulator::setup_stack(Vector aux_vector) Vector argv_entries; - for (auto& argument : m_arguments) { + for (auto const& argument : m_arguments) { m_cpu.push_string(argument); argv_entries.append(m_cpu.esp().value()); } Vector env_entries; - for (auto& variable : m_environment) { + for (auto const& variable : m_environment) { m_cpu.push_string(variable.characters()); env_entries.append(m_cpu.esp().value()); } @@ -461,7 +461,7 @@ String Emulator::create_backtrace_line(FlatPtr address) void Emulator::dump_backtrace(Vector const& backtrace) { - for (auto& address : backtrace) { + for (auto const& address : backtrace) { reportln("{}", create_backtrace_line(address)); } } diff --git a/Userland/DevTools/UserspaceEmulator/Emulator_syscalls.cpp b/Userland/DevTools/UserspaceEmulator/Emulator_syscalls.cpp index 28f7672026..974fda2eb3 100644 --- a/Userland/DevTools/UserspaceEmulator/Emulator_syscalls.cpp +++ b/Userland/DevTools/UserspaceEmulator/Emulator_syscalls.cpp @@ -1493,7 +1493,7 @@ int Emulator::virt$clock_nanosleep(FlatPtr params_addr) mmu().copy_from_vm(&requested_sleep, (FlatPtr)params.requested_sleep, sizeof(timespec)); params.requested_sleep = &requested_sleep; - auto remaining_vm_addr = params.remaining_sleep; + auto* remaining_vm_addr = params.remaining_sleep; timespec remaining { 0, 0 }; params.remaining_sleep = &remaining; diff --git a/Userland/DevTools/UserspaceEmulator/MmapRegion.cpp b/Userland/DevTools/UserspaceEmulator/MmapRegion.cpp index f5b145c8cf..9ddd3cfda3 100644 --- a/Userland/DevTools/UserspaceEmulator/MmapRegion.cpp +++ b/Userland/DevTools/UserspaceEmulator/MmapRegion.cpp @@ -27,8 +27,8 @@ static void free_pages(void* ptr, size_t bytes) NonnullOwnPtr MmapRegion::create_anonymous(u32 base, u32 size, u32 prot, String name) { - auto data = (u8*)mmap_initialized(size, 0, String::formatted("(UE) {}", name).characters()); - auto shadow_data = (u8*)mmap_initialized(size, 1, "MmapRegion ShadowData"); + auto* data = (u8*)mmap_initialized(size, 0, String::formatted("(UE) {}", name).characters()); + auto* shadow_data = (u8*)mmap_initialized(size, 1, "MmapRegion ShadowData"); auto region = adopt_own(*new MmapRegion(base, size, prot, data, shadow_data)); region->m_name = move(name); return region; @@ -38,9 +38,9 @@ NonnullOwnPtr MmapRegion::create_file_backed(u32 base, u32 size, u32 { // Since we put the memory to an arbitrary location, do not pass MAP_FIXED to the Kernel. auto real_flags = flags & ~MAP_FIXED; - auto data = (u8*)mmap_with_name(nullptr, size, prot, real_flags, fd, offset, name.is_empty() ? nullptr : String::formatted("(UE) {}", name).characters()); + auto* data = (u8*)mmap_with_name(nullptr, size, prot, real_flags, fd, offset, name.is_empty() ? nullptr : String::formatted("(UE) {}", name).characters()); VERIFY(data != MAP_FAILED); - auto shadow_data = (u8*)mmap_initialized(size, 1, "MmapRegion ShadowData"); + auto* shadow_data = (u8*)mmap_initialized(size, 1, "MmapRegion ShadowData"); auto region = adopt_own(*new MmapRegion(base, size, prot, data, shadow_data)); region->m_file_backed = true; region->m_name = move(name); diff --git a/Userland/DevTools/UserspaceEmulator/RangeAllocator.cpp b/Userland/DevTools/UserspaceEmulator/RangeAllocator.cpp index 2c93167df8..e22980b397 100644 --- a/Userland/DevTools/UserspaceEmulator/RangeAllocator.cpp +++ b/Userland/DevTools/UserspaceEmulator/RangeAllocator.cpp @@ -28,7 +28,7 @@ void RangeAllocator::initialize_with_range(VirtualAddress base, size_t size) void RangeAllocator::dump() const { dbgln("RangeAllocator({})", this); - for (auto& range : m_available_ranges) { + for (auto const& range : m_available_ranges) { dbgln(" {:x} -> {:x}", range.base().get(), range.end().get() - 1); } } diff --git a/Userland/DevTools/UserspaceEmulator/main.cpp b/Userland/DevTools/UserspaceEmulator/main.cpp index cad02f58d9..da4975644f 100644 --- a/Userland/DevTools/UserspaceEmulator/main.cpp +++ b/Userland/DevTools/UserspaceEmulator/main.cpp @@ -65,7 +65,7 @@ int main(int argc, char** argv, char** env) if (dump_profile) { profile_output_file = fopen(profile_dump_path.characters(), "w+"); if (profile_output_file == nullptr) { - auto error_string = strerror(errno); + char const* error_string = strerror(errno); warnln("Failed to open '{}' for writing: {}", profile_dump_path, error_string); return 1; }