From 15dc48b43125210f3376f019cdc60babd82f568b Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Thu, 17 Mar 2022 12:32:21 +0100 Subject: [PATCH] LibWeb: Make PaintableBox::enclosing_stacking_context() cheaper No need to call the expensive establishes_stacking_context() here, as we've already built the stacking context tree and can simply test for the presence of existing stacking contexts. --- Userland/Libraries/LibWeb/Painting/PaintableBox.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Userland/Libraries/LibWeb/Painting/PaintableBox.cpp b/Userland/Libraries/LibWeb/Painting/PaintableBox.cpp index a4c65f1b3e..e0685a5b07 100644 --- a/Userland/Libraries/LibWeb/Painting/PaintableBox.cpp +++ b/Userland/Libraries/LibWeb/Painting/PaintableBox.cpp @@ -86,10 +86,8 @@ Painting::StackingContext* PaintableBox::enclosing_stacking_context() if (!is(ancestor)) continue; auto& ancestor_box = static_cast(const_cast(*ancestor)); - if (!ancestor_box.establishes_stacking_context()) - continue; - VERIFY(ancestor_box.paint_box()->stacking_context()); - return const_cast(ancestor_box.paint_box()->stacking_context()); + if (auto* ancestor_paint_box = ancestor_box.paint_box(); ancestor_paint_box && ancestor_paint_box->stacking_context()) + return const_cast(ancestor_paint_box->stacking_context()); } // We should always reach the Layout::InitialContainingBlock stacking context. VERIFY_NOT_REACHED();