RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 22:44:58 +00:00
Code Issues Activity Actions

LibWeb: Layout viewport rect was lagging behind when resizing

Browse source 
Layout was using an outdated viewport rect that we set *after* doing
a layout due to resize. That meant that layout-in-response-to-resize
was always lagging behind the current size of the view.

The root of this problem was how Frame kept both a viewport rect
(with both scroll offset and size) and a frame size. To fix this,
only store the viewport scroll offset, and always use the frame size.
This way they can't get out of sync and the problem goes away. :^)

Fixes #4250.
This commit is contained in:
Andreas Kling 2020-12-02 23:40:57 +01:00
parent 766db673c1
commit 15e35b0d71
4 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/InProcessWebView.cpp
View file

@ -248,7 +248,7 @@ void InProcessWebView::layout_and_sync_size()
set_content_size(layout_root()->size().to_type<int>());
}
page().main_frame().set_viewport_rect(viewport_rect_in_content_coordinates());
page().main_frame().set_viewport_scroll_offset({ horizontal_scrollbar().value(), vertical_scrollbar().value() });
}
void InProcessWebView::resize_event(GUI::ResizeEvent& event)
@ -409,7 +409,7 @@ void InProcessWebView::set_document(DOM::Document* document)
void InProcessWebView::did_scroll()
{
page().main_frame().set_viewport_rect(viewport_rect_in_content_coordinates());
page().main_frame().set_viewport_scroll_offset({ horizontal_scrollbar().value(), vertical_scrollbar().value() });
page().main_frame().did_scroll({});
}